mem/mem_pool: use pointer-pointer to prevent heap-use-after-free #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `mem_pool_entry` pointer is stored by application a `mem_pool_extend` invalidates this pointer. This PR uses a pointer-pointer list to keep old `mem_pool_entry` pointers intact.
jmontorosf
pushed a commit
to sipfront/re
that referenced
this pull request
Jun 12, 2025
…esip#1290) If mem_pool_entry pointer is stored by application a mem_pool_extend derefs this pointer. This PR uses a pointer-pointer list to keep old mem_pool_entry pointers intact. Fixes baresip/baresip#3338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
mem_pool_entrypointer is stored by application amem_pool_extendderefs this pointer. This PR uses a pointer-pointer list to keep oldmem_pool_entrypointers intact.Fixes baresip/baresip#3338