Skip to content

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Apr 10, 2025

No description provided.

@cspiel1 cspiel1 marked this pull request as ready for review April 10, 2025 13:25
@alfredh
Copy link
Contributor

alfredh commented Apr 11, 2025

looks great ...

Should we also update the application code to use mbuf functions instead of poking
directly into the struct mbuf (pos, end, ...) ?

This would enable us to make struct mbuf opaque, which would improve ABI changes ...

@cspiel1
Copy link
Collaborator Author

cspiel1 commented Apr 14, 2025

There are a lot of direct access to mb->pos and mb->end in baresip and much more in other modules of re. It would be a dramatic change. Further there might be a lot of applications that depend on re. I wouldn't do this.

@sreimers sreimers merged commit 015259f into baresip:main Apr 14, 2025
38 checks passed
@cspiel1 cspiel1 deleted the mbuf_null_pointer_checks_for_inline_functions branch April 17, 2025 09:18
jmontorosf pushed a commit to sipfront/re that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants