Skip to content

Simplify chokidar event handler #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2014
Merged

Simplify chokidar event handler #271

merged 2 commits into from
Dec 8, 2014

Conversation

es128
Copy link
Member

@es128 es128 commented Dec 8, 2014

Chokidar provides an all event, making it possible to bind just one handler instead of iterating to bind several that are all doing the same thing.

@sebmck
Copy link
Contributor

sebmck commented Dec 8, 2014

This might cause unexpected behaviour because it'll catch some events that we don't need to handle.

@es128
Copy link
Member Author

es128 commented Dec 8, 2014

The only other events emitted under all are addDir and unlinkDir. If you don't think a rebuild ought to be triggered for those, then it's easy to filter them out: es128@5e67dfb. Still better than binding the handler separately three times.

sebmck added a commit that referenced this pull request Dec 8, 2014
@sebmck
Merge pull request #271 from es128/patch-1
ccb56fe 
Simplify chokidar event handler
@sebmck sebmck merged commit ccb56fe into babel:master Dec 8, 2014
@sebmck
Copy link
Contributor

sebmck commented Dec 8, 2014

Great, thanks!

@es128 es128 deleted the patch-1 branch December 8, 2014 22:58
existentialism pushed a commit that referenced this pull request Oct 5, 2017
Remove deprecated comment (#271)
d60cd65
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@es128 @sebmck @jamiebuilds