Skip to content

SO-6372: RF2 import result dialogue bug #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 14, 2025
Merged

SO-6372: RF2 import result dialogue bug #1366

merged 7 commits into from
Feb 14, 2025

Conversation

adamfilep
Copy link
Contributor

@adamfilep adamfilep commented Feb 14, 2025 •
edited
Loading

@adamfilep adamfilep self-assigned this Feb 14, 2025
@adamfilep adamfilep changed the title SO-6372: Import result dialogue bug SO-6372: RF2 import result dialogue bug Feb 14, 2025
@apeteri
Copy link
Member

apeteri commented Feb 14, 2025

A serialization test case still needs to be amended as "changeCount": 1 is now also returned:

Failures: 
  ImportResponseSerializationTest.testSerialization:56 
  expected:<...e","type":"INFO"}],"[]success":true}> 
  but was: <...e","type":"INFO"}],"[changeCount":1,"]success":true}>

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.25%. Comparing base (3f89056) to head (0dd73a6).
Report is 113 commits behind head on 9.x.

Files with missing lines Patch % Lines
...tional/snowowl/core/request/io/ImportResponse.java 50.00% 1 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                9.x    #1366      +/-   ##
============================================
+ Coverage     64.11%   64.25%   +0.14%     
- Complexity    12629    12673      +44     
============================================
  Files          1614     1614              
  Lines         57333    57352      +19     
  Branches       5637     5645       +8     
============================================
+ Hits          36760    36854      +94     
+ Misses        18231    18152      -79     
- Partials       2342     2346       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

apeteri
apeteri approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apeteri apeteri merged commit ad63b5c into 9.x Feb 14, 2025
5 checks passed
@apeteri apeteri deleted the issue/SO-6372-import-result-dialogue-bug branch February 14, 2025 21:29
AAAlinaaa pushed a commit that referenced this pull request Feb 15, 2025
@apeteri @AAAlinaaa
Merge pull request #1366 from issue/SO-6372-import-result-dialog-bug
022fe34
@nagyo nagyo added the port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream label Feb 17, 2025
@nagyo nagyo mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeteri apeteri apeteri approved these changes

@AAAlinaaa AAAlinaaa AAAlinaaa approved these changes

Assignees

@adamfilep adamfilep

Labels
port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamfilep @apeteri @AAAlinaaa @nagyo