Skip to content

Conversation

neutrinoceros
Copy link
Contributor

Description

This is a follow up to #16766 as requested by @saimn

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review July 26, 2024 13:19
@neutrinoceros neutrinoceros requested a review from saimn as a code owner July 26, 2024 13:19
@pllim pllim added this to the v6.1.3 milestone Jul 26, 2024
@pllim
Copy link
Member

pllim commented Jul 26, 2024

Thanks! LGTM but I'll give Simon a chance to review.

Copy link
Contributor

@saimn saimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neutrinoceros !

@saimn saimn merged commit 249a9e3 into astropy:main Jul 26, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jul 26, 2024
@neutrinoceros neutrinoceros deleted the tst/refine_16766 branch July 26, 2024 17:04
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Jul 26, 2024

Ah, of course I'm only realizing now but the warning should only be expected to go off if we have numpy 2... I'll open a third PR

update: this is #16778

saimn added a commit that referenced this pull request Jul 26, 2024
…775-on-v6.1.x

Backport PR #16775 on branch v6.1.x (TST: avoid excessive warning filtering in a io.fits test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants