Skip to content

chore: replace heptio-images with argocd-e2e-container #23040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

chore: replace heptio-images with argocd-e2e-container #23040

merged 2 commits into from
May 19, 2025

Conversation

nitishfy
Copy link
Member

@nitishfy nitishfy commented May 19, 2025 •
edited
Loading

PR to replace heptio-images with argocd-e2e-container image that is widely used in the project either for example application, installation purpose etc.

Related to

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nitishfy
replace heptio-images with argocd-e2e-container
243c95e 
Signed-off-by: nitishfy <justnitish06@gmail.com>
@nitishfy nitishfy requested review from a team as code owners May 19, 2025 14:05
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented May 19, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@nitishfy
Merge branch 'master' into replace-image
3ad7a23 
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
@codecov Codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.02%. Comparing base (90408cb) to head (3ad7a23).
⚠️ Report is 461 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23040      +/-   ##
==========================================
- Coverage   60.02%   60.02%   -0.01%     
==========================================
  Files         343      343              
  Lines       57846    57846              
==========================================
- Hits        34723    34721       -2     
- Misses      20353    20355       +2     
  Partials     2770     2770

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rumstead rumstead merged commit 309acd1 into argoproj:master May 19, 2025
28 checks passed
@nitishfy nitishfy deleted the replace-image branch May 19, 2025 15:06
@nitishfy
Copy link
Member Author

/cherry-pick 2.14

@nitishfy
Copy link
Member Author

/cherry-pick release-2.14

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 309acd161c7cf20e99970f06d04efc4eb78a00a9 into temp-cherry-pick-320975-release-2.14

@nitishfy
Copy link
Member Author

/cherry-pick release-3.0

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 309acd161c7cf20e99970f06d04efc4eb78a00a9 into temp-cherry-pick-320975-release-3.0

@nitishfy
Copy link
Member Author

nitishfy commented May 19, 2025 •
edited
Loading

/cherry-pick release-2.13

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 309acd161c7cf20e99970f06d04efc4eb78a00a9 into temp-cherry-pick-320975-release-3.0

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 309acd161c7cf20e99970f06d04efc4eb78a00a9 into temp-cherry-pick-320975-release-2.13

@nitishfy
Copy link
Member Author

/cherry-pick release-3.0

@nitishfy
Copy link
Member Author

/cherry-pick release-2.13

nitishfy added a commit to nitishfy/argo-cd that referenced this pull request May 20, 2025
@nitishfy
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
9ddcffe 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
(cherry picked from commit 309acd1)
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@nitishfy @ranakan19
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
3165b31 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
nitishfy added a commit to nitishfy/argo-cd that referenced this pull request May 20, 2025
@nitishfy
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
d355166 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
@nitishfy nitishfy mentioned this pull request May 20, 2025
Merged
14 tasks
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@nitishfy @olivergondza
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
1f8edf0 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
nitishfy added a commit to nitishfy/argo-cd that referenced this pull request May 20, 2025
@nitishfy
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
509afb0 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
oleksandr-codefresh pushed a commit to codefresh-io/argo-cd that referenced this pull request May 20, 2025
@nitishfy @oleksandr-codefresh
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
0875fd0 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>

(cherry picked from commit 309acd1)
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
nitishfy added a commit to nitishfy/argo-cd that referenced this pull request May 20, 2025
@nitishfy
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
1e8b355 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
This was referenced May 20, 2025
Closed
Merged
oleksandr-codefresh added a commit to codefresh-io/argo-cd that referenced this pull request May 20, 2025
@oleksandr-codefresh @reggie-k @nitishfy
chore: sync all codefresh code changes into v3.0.2 (#397)
6e4ca19 
* chore: sync all codefresh code changes into v3.0.2 without event-reporter related changes

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* removed cf script

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* upgraded git-lfs to 3.6.1 in Dockerfile (#386)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* fixed webstorm go.mod issue

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* e2e: improved error logs

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* fixed changes on generated files

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* chore: replace heptio-images with argocd-e2e-container (argoproj#23040)

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>

(cherry picked from commit 309acd1)
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* feat: upgraded github.com/expr-lang/expr from 0.16.9 to 0.17.0

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

* e2e [TestTrackAppStateAndSyncApp / TestNewStyleResourceActionMixedOk / TestNewStyleResourceActionPermitted / TestNamespacedPermissions]: added wait for sync operation

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>

---------

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
@nitishfy @LyhengTep
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
f163102 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Lyheng <lyhengtep@gmail.com>
reggie-k pushed a commit that referenced this pull request May 27, 2025
@nitishfy
chore: replace heptio-images with argocd-e2e-container (cherry-pick #…
6612b7b 
…23040) (#23056)

Signed-off-by: nitishfy <justnitish06@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@nitishfy @tylerrosnett
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
69d5287 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
reggie-k pushed a commit that referenced this pull request Jun 3, 2025
@nitishfy
chore: replace heptio-images with argocd-e2e-container (cherry-pick #…
001848e 
…23040) (#23058)

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@nitishfy @chansuke
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
b8b669f 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@nitishfy @dsuhinin
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
241bd67 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@nitishfy @dsuhinin
chore: replace heptio-images with argocd-e2e-container (argoproj#23040)
86e76d3 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumstead rumstead rumstead approved these changes

+1 more reviewer

@mkilchhofer mkilchhofer mkilchhofer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitishfy @mkilchhofer @rumstead