Skip to content

Conversation

oleksandr-codefresh
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

oleksandr-codefresh and others added 5 commits May 20, 2025 11:49
…rter related changes

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
oleksandr-codefresh and others added 2 commits May 20, 2025 12:20
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>

(cherry picked from commit 309acd1)
Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 18.03738% with 877 lines in your changes missing coverage. Please review.

Please upload report for BASE (sync-3.0.2@8a7c0f0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/application/application_rollout_rollback.go 0.00% 159 Missing ⚠️
...commands/application_change_revision_controller.go 2.80% 104 Missing ⚠️
acr_controller/server.go 0.00% 95 Missing ⚠️
acr_controller/service/acr_service.go 52.48% 59 Missing and 8 partials ⚠️
...r/application/application_validate_src_and_dest.go 0.00% 67 Missing ⚠️
acr_controller/application/client.go 0.00% 58 Missing ⚠️
acr_controller/controller/broadcaster.go 0.00% 52 Missing ⚠️
reposerver/repository/cf_repository.go 23.52% 50 Missing and 2 partials ⚠️
acr_controller/controller/controller.go 0.00% 38 Missing ⚠️
util/kustomize/repospec.go 64.70% 31 Missing and 5 partials ⚠️
... and 11 more
Additional details and impacted files
@@              Coverage Diff              @@
##             sync-3.0.2     #397   +/-   ##
=============================================
  Coverage              ?   55.22%           
=============================================
  Files                 ?      358           
  Lines                 ?    58445           
  Branches              ?        0           
=============================================
  Hits                  ?    32274           
  Misses                ?    23512           
  Partials              ?     2659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
…/ TestNewStyleResourceActionPermitted / TestNamespacedPermissions]: added wait for sync operation

Signed-off-by: oleksandr-codefresh <oleksandr.saulyak@octopus.com>
@oleksandr-codefresh oleksandr-codefresh merged commit 6e4ca19 into sync-3.0.2 May 20, 2025
23 checks passed
@ATGardner ATGardner deleted the make-cf-changes branch June 22, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants