Skip to content

Conversation

igaskin
Copy link
Member

@igaskin igaskin commented Feb 25, 2025

bumped patch version to 3.17.1 to support nulling of subcharts

#21962

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Feb 25, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

bumped patch version to 3.17.1 to support nulling of subcharts

argoproj#21962

Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
@igaskin igaskin marked this pull request as ready for review February 25, 2025 18:57
@igaskin igaskin requested a review from a team as a code owner February 25, 2025 18:57
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) February 25, 2025 19:07
@crenshaw-dev crenshaw-dev merged commit 644af54 into argoproj:master Feb 25, 2025
25 of 26 checks passed
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.90%. Comparing base (402802b) to head (b4b8442).
Report is 439 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22009      +/-   ##
==========================================
- Coverage   55.79%   53.90%   -1.90%     
==========================================
  Files         342      342              
  Lines       57040    57040              
==========================================
- Hits        31828    30749    -1079     
- Misses      22589    23703    +1114     
+ Partials     2623     2588      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Feb 26, 2025
Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
chzar pushed a commit to chzar/argo-cd that referenced this pull request Mar 3, 2025
Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Mar 4, 2025
Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants