chore: Graceful shutdown for API Server (redo) (#18642) (cherry-pick #21224) #21229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Graceful shutdown for the API server (#18642) (#20981) * fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
pasha-codefresh
approved these changes
Dec 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-2.14 #21229 +/- ##
================================================
+ Coverage 55.01% 55.18% +0.16%
================================================
Files 338 338
Lines 57075 57167 +92
================================================
+ Hits 31401 31548 +147
+ Misses 22972 22920 -52
+ Partials 2702 2699 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked chore: Graceful shutdown for API Server (#18642) (#21224)
fix: Graceful shutdown for the API server (Implement graceful shutdown in all Argo CD components #18642) (fix: Graceful shutdown for the API server (#18642) #20981)
fix: Graceful shutdown for the API server (Implement graceful shutdown in all Argo CD components #18642)
Closes #18642
Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Co-authored-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Co-authored-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com
Co-authored-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com