Skip to content

Implement graceful shutdown in all Argo CD components #18642

@crenshaw-dev

Description

@crenshaw-dev

Procfile sets GOCOVDIR for five Argo CD components. But only one (applicationset-controller) shuts down gracefully enough for code coverage data to be produced. In other words, go writes a covmeta file, but not a covcounters file (the file that actually contains coverage info). So today we get partial code coverage info for e2e tests.

The task is to do two things for the remaining four components: 1) implement graceful shutdown and 2) add the component's gocov directory to the e2e reporting CI.

  • applicationset-controller
  • controller
  • api-server (WIP)
  • repo-server
  • notification

Exactly what "graceful shutdown means" may vary by component. Concretely, I think it means we need to listen to shutdown signals and end all running goroutines. But the "graceful" part depends on what's running.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcomponent:apiAPI bugs and enhancementscomponent:application-setsIssue related to the ApplicationSet controllercomponent:notificationsIssue related to the notifications subsystemcomponent:repo-serverIssue related to the Repository Server componentversion:2.14Latest confirmed affected version is 2.14

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions