chore: revert "fix: Graceful shutdown for the API server (#18642) (#20981)" #21221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgoproj#20981)" This reverts commit 730363f.
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
crenshaw-dev
approved these changes
Dec 17, 2024
rumstead
approved these changes
Dec 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21221 +/- ##
==========================================
+ Coverage 53.22% 55.05% +1.83%
==========================================
Files 338 338
Lines 57164 57075 -89
==========================================
+ Hits 30425 31423 +998
+ Misses 24079 22958 -1121
- Partials 2660 2694 +34 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-2.14 |
pasha-codefresh
pushed a commit
that referenced
this pull request
Dec 17, 2024
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
…rgoproj#20981)" (argoproj#21221) Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not compatible with Windows and is blocking the 2.14 release.
Error during the release:
Discussion thread: