fix: Graceful shutdown for the API server (#18642) #20981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
13 tasks
fd682a9 to
ac80298
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20981 +/- ##
==========================================
+ Coverage 55.02% 55.24% +0.21%
==========================================
Files 324 324
Lines 55472 55572 +100
==========================================
+ Hits 30522 30699 +177
+ Misses 22329 22257 -72
+ Partials 2621 2616 -5 ☔ View full report in Codecov by Sentry. |
8280700 to
a8ca06a
Compare
badea03 to
240c2d5
Compare
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
This was referenced Dec 9, 2024
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
to crenshaw-dev/argo-cd
that referenced
this pull request
Dec 17, 2024
…rgoproj#20981)" This reverts commit 730363f. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
pasha-codefresh
added a commit
to pasha-codefresh/argo-cd
that referenced
this pull request
Dec 17, 2024
…rgoproj#20981)" This reverts commit 730363f.
pasha-codefresh
added a commit
that referenced
this pull request
Dec 17, 2024
pasha-codefresh
pushed a commit
that referenced
this pull request
Dec 17, 2024
andrii-korotkov-verkada
added a commit
to andrii-korotkov-verkada/argo-cd
that referenced
this pull request
Dec 17, 2024
…20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
leoluz
added a commit
that referenced
this pull request
Dec 17, 2024
* fix: Graceful shutdown for the API server (#18642) (#20981) * fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix: Graceful shutdown for the API server (#18642) (#20981) * fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
pasha-codefresh
pushed a commit
that referenced
this pull request
Dec 18, 2024
* fix: Graceful shutdown for the API server (#18642) (#20981) * fix: Graceful shutdown for the API server (#18642) Closes #18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. * Init server only once, but keep re-initializing listeners * Check error for SetParamInSettingConfigMap as needed after fresh master * Prevent a data race * Remove unused variable, don't pass lock when not necessary * Try overriding URL instead of additional URLs * Use a more specific url --------- * Use a custom signal for graceful restart * Re-run tests --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Andrii Korotkov <137232734+andrii-korotkov-verkada@users.noreply.github.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
…rgoproj#20981)" (argoproj#21221) Signed-off-by: Brett C. Dudo <brett@dudo.io>
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
) * fix: Graceful shutdown for the API server (argoproj#18642) (argoproj#20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
…20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
) * fix: Graceful shutdown for the API server (argoproj#18642) (argoproj#20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Closed
7 tasks
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
) * fix: Graceful shutdown for the API server (argoproj#18642) (argoproj#20981) * fix: Graceful shutdown for the API server (argoproj#18642) Closes argoproj#18642 Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Init server only once, but keep re-initializing listeners Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Check error for SetParamInSettingConfigMap as needed after fresh master Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Prevent a data race Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Remove unused variable, don't pass lock when not necessary Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Try overriding URL instead of additional URLs Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Use a more specific url Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Use a custom signal for graceful restart Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Re-run tests Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18642
fix #18576
Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.
Checklist: