Skip to content

feat: add pause action for argo-rollouts #20505 #20506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 18, 2025
Merged

feat: add pause action for argo-rollouts #20505 #20506

merged 22 commits into from
May 18, 2025

Conversation

sedflix
Copy link
Contributor

@sedflix sedflix commented Oct 23, 2024 •
edited by reggie-k
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Closes #20505

Does this PR require documentation updates?

I will raise a PR in argo-rollouts docs latter.

@sedflix
feat: add pause action for argo-rollouts
9c9361e 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
@sedflix sedflix requested a review from a team as a code owner October 23, 2024 16:03
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 23, 2024 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 23, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@sedflix
update resource_actions_builtin.md
de77018 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
@sedflix sedflix requested a review from a team as a code owner October 23, 2024 16:11
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@38b0fd5). Learn more about missing BASE report.
Report is 384 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #20506   +/-   ##
=========================================
  Coverage          ?   55.68%           
=========================================
  Files             ?      341           
  Lines             ?    56997           
  Branches          ?        0           
=========================================
  Hits              ?    31741           
  Misses            ?    22606           
  Partials          ?     2650

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nitishfy
nitishfy reviewed Oct 24, 2024
View reviewed changes
nitishfy
nitishfy approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM with a minor nit added.

@nitishfy nitishfy mentioned this pull request Oct 25, 2024
Closed
6 tasks
andrii-korotkov-verkada
andrii-korotkov-verkada reviewed Nov 9, 2024
View reviewed changes
resource_customizations/argoproj.io/Rollout/actions/pause/action.lua
@@ -0,0 +1,2 @@
obj.spec.paused = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something picked up by the Rollouts controller?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's picked up by the controller.
Link to the CRD: https://github.com/argoproj/argo-rollouts/blob/master/manifests/crds/rollout-crd.yaml#L66

resource_customizations/argoproj.io/Rollout/actions/action_test.yaml
@@ -35,6 +39,8 @@ discoveryTests:
disabled: true
- name: promote-full
disabled: true
- name: pause
disabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the inputPath makes me think this might have to be true, since it's already paused. But not sure what's nil means there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nil_paused implies no "paused" spec is present in the rollout spec and hence the rollout is not paused.
Therefore, it should enabled.

resource_customizations/argoproj.io/Rollout/actions/action_test.yaml
@@ -47,6 +53,8 @@ discoveryTests:
disabled: true
- name: promote-full
disabled: false
- name: pause
disabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar here, has pause condition seems to mean that it's already paused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two types of "pause" one done using "paused" in spec and one using "status". The pause in the status can be temporary and as a part of the rollout. If the rollout is paused temporarily as a part of the rollout, the user would still want to pause the rollout permanently.

@ctenberge-oneid
Copy link

Is there anything I can help with to push this along?
Thanks everyone for the contributions.

@reggie-k reggie-k merged commit f763b2a into argoproj:master May 18, 2025
27 checks passed
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@sedflix @nitishfy @ranakan19
feat: add pause action for argo-rollouts argoproj#20505 (argoproj#20506)
15c8fef 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
Signed-off-by: siddharth <sedflix@gmail.com>
Co-authored-by: Siddharth Yadav <siddharth.yadav@king.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@sedflix @nitishfy @olivergondza
feat: add pause action for argo-rollouts argoproj#20505 (argoproj#20506)
433da52 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
Signed-off-by: siddharth <sedflix@gmail.com>
Co-authored-by: Siddharth Yadav <siddharth.yadav@king.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
@sedflix @nitishfy @LyhengTep
feat: add pause action for argo-rollouts argoproj#20505 (argoproj#20506)
daa6d96 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
Signed-off-by: siddharth <sedflix@gmail.com>
Co-authored-by: Siddharth Yadav <siddharth.yadav@king.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Lyheng <lyhengtep@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@sedflix @nitishfy @tylerrosnett
feat: add pause action for argo-rollouts argoproj#20505 (argoproj#20506)
8c3d1e5 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
Signed-off-by: siddharth <sedflix@gmail.com>
Co-authored-by: Siddharth Yadav <siddharth.yadav@king.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@sedflix @nitishfy @chansuke
feat: add pause action for argo-rollouts argoproj#20505 (argoproj#20506)
6b036e3 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
Signed-off-by: siddharth <sedflix@gmail.com>
Co-authored-by: Siddharth Yadav <siddharth.yadav@king.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@sedflix @nitishfy @dsuhinin
feat: add pause action for argo-rollouts argoproj#20505 (argoproj#20506)
ad58555 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
Signed-off-by: siddharth <sedflix@gmail.com>
Co-authored-by: Siddharth Yadav <siddharth.yadav@king.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@sedflix @nitishfy @dsuhinin
feat: add pause action for argo-rollouts argoproj#20505 (argoproj#20506)
b47e608 
Signed-off-by: Siddharth Yadav <siddharth.yadav@king.com>
Signed-off-by: siddharth <sedflix@gmail.com>
Co-authored-by: Siddharth Yadav <siddharth.yadav@king.com>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reggie-k reggie-k reggie-k approved these changes

@nitishfy nitishfy nitishfy approved these changes

@andrii-korotkov-verkada andrii-korotkov-verkada Awaiting requested review from andrii-korotkov-verkada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Pause" Resource Action for Argo Rollout
5 participants
@sedflix @ctenberge-oneid @reggie-k @nitishfy @andrii-korotkov-verkada