Skip to content

Conversation

leehosu
Copy link
Member

@leehosu leehosu commented Sep 29, 2024

summary

Fixes #20141

This PR addresses the issue of hybrid cluster support (Linux and Windows nodes) by adding a nodeSelector to ensure the following components are deployed only on Linux nodes:

argocd-application-controller
argocd-applicationset-controller
argocd-repo-server
argocd-dex-server
argocd-server

Modified the deployment YAML files to include nodeSelector: kubernetes.io/os: linux to prevent scheduling on non-Linux nodes.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

…licationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu leehosu requested a review from a team as a code owner September 29, 2024 17:35
Copy link

bunnyshell bot commented Sep 29, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 29, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@0681098). Learn more about missing BASE report.
Report is 432 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20148   +/-   ##
=========================================
  Coverage          ?   55.89%           
=========================================
  Files             ?      321           
  Lines             ?    44497           
  Branches          ?        0           
=========================================
  Hits              ?    24870           
  Misses            ?    17054           
  Partials          ?     2573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: l2h <hosu4549@gmail.com>
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Can you also add this small point in the documentation too?

@leehosu
Copy link
Member Author

leehosu commented Sep 30, 2024

@nitishfy Sure! Please let me know which documents I can add to. And I wonder why PR inspection is not successful.

@@ -264,3 +264,5 @@ spec:
items:
- key: controller.profile.enabled
path: profiler.enabled
nodeSelector:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard coding this for all users this it can be an optional kustomization, we can document it in the docs to let users know how/when to use the kustomization if needed instead.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the concern about adding this globally?

I'm not seeing a downside to applying this as it will have no effect on clusters that only have Linux nodes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit ignorant about multi-OS clusters. Do we know with reasonable certainty that kubernetes.io/os will be set for all nodes for all relevant versions of Kubernetes across all major vendors? Or is it just a convention that may or may not be in place?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is autopopulated by Kubernetes. See the docs

For nodes, the kubelet populates this with runtime.GOOS as defined by Go.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all current kubernetes clusters (version 1.14 (2019) to present (v1.31)), the kubernetes.io/os label is automatically set. Previous to that, the label was beta.kubernetes.io/os. Versions since 1.14 seem to have both labels for reverse compatibility, but officially, beta is deprecated.

Copy link

@andorrafields andorrafields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the nodeSelector should also be added to argocd-dex-server and argocd-server deployment yamls.

@leehosu
Copy link
Member Author

leehosu commented Sep 30, 2024

@andorrafields Oh! Thank you for mentioning the missing part. I've completed the work, and a commit has been added to the PR.

@rumstead
Copy link
Member

rumstead commented Sep 30, 2024

Makes sense to me. We need to run:
make manifests-local
to apply the changes to all the kustomize files.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright. Will wait for 2.14 so we have more time to catch any issues.

@crenshaw-dev
Copy link
Member

@leehosu looks like codegen is failing, can you take a look?

Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
Copy link
Member Author

leehosu commented Sep 30, 2024

@crenshaw-dev Okay. Actually, I've been trying, but I don't know what caused it... I just posted a commit. I'll wait for the results.

@rumstead
Copy link
Member

Makes sense to me. We need to run: make manifests-local to apply the changes to all the kustomize files.

@leehosu that should fix the code gen issue.

Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
Copy link
Member Author

leehosu commented Sep 30, 2024

@rumstead Thank you for your help! I ran the command and pushed the results after executing it. Now I'm waiting for the results, hoping everything goes well.

@crenshaw-dev crenshaw-dev dismissed gdsoumya’s stale review October 1, 2024 16:12

Seems safe to implement globally. @gdsoumya, let us know if you hit issues!

@crenshaw-dev crenshaw-dev merged commit ab8fdb8 into argoproj:master Oct 1, 2024
25 checks passed
@leehosu leehosu deleted the feat/fix-node-selector-linux-only branch October 2, 2024 09:18
moleus pushed a commit to moleus/argo-cd that referenced this pull request Oct 7, 2024
* feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor : Reversal the wrong part and correct it.

Signed-off-by: leehosu <hosu4549@gmail.com>

* Update argocd-application-controller-statefulset.yaml

Signed-off-by: l2h <hosu4549@gmail.com>

* feat: Add nodeSelector for Linux nodes in dex-server, argo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for intergration test

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for codegen

Signed-off-by: leehosu <hosu4549@gmail.com>

* Run make manifests-local and then commit

Signed-off-by: leehosu <hosu4549@gmail.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>
gdsoumya pushed a commit that referenced this pull request Oct 7, 2024
…#20085)

* docs: Add `404 Not Found` github notification error to troubleshooting docs

Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by upgrading path-to-regexp from 1.8.0 to 1.9.0 (#20087)

Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps-dev): bump @types/node from 22.5.5 to 22.7.2 in /ui-test (#20112)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.5 to 22.7.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(extension): add header to support apps-in-any-namespace (#20123)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fix typo (#20127)

Remove a redundant "is".

Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): add optional check to avoid undefined reference in project detail (#20044)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump Helm from 3.15.2 to 3.15.4 (#20135)

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: oras-go client should fallback to docker config if no credentials specified (#18133)

* oras-go client should fallback to docker config if no credentials specified

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix tests

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix lint

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* gofumpt

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Validate auth header

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

---------

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (#20154)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.7.0 to 6.8.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@5cd11c3...32945a3)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix argocd appset generate failure due to missing clusterrole (#20162)

* fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: update generated code

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (#20146)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: repo generate paths value in namespace install is incorrectly formatted (#20139)

* Fix repo generate paths value in namespace install

Signed-off-by: todaywasawesome <dan@codefresh.io>

* Fix in base and regen

Signed-off-by: todaywasawesome <dan@codefresh.io>

---------

Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: introduce pause/unpause actions for Numaplane CRDs (#20128)

* feat: introduce pause/unpause actions for Numaplane CRDs

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: fixed incorrect file names

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: codegen

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: empty check for lifecycle

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil check

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil checks

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: testing different starting spec

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* feat: add nil checks for all possible nil fields

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: rerun tests

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

---------

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation (#18703)

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Use local client rather than custom cache

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Clean go.mod

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Merge master

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix after merging master
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Initialize appProject variable inside loop

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Remove unused ArgoAppClientset field
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix linter issue
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

---------

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: added note re. arch of example application on getting_started.md (#20143)

added warning that example application may not run on all archs

Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): hide resource actions menu if it's empty (#20051)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fixes minor typo which lead to using the bearer token as api URL and was obviously not working. (#20169)

Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Try to make CodeQL happy (#20094) (#20129)

* chore(common): Split const from unrelated util/clusterauth const

Signed-off-by: Josh Soref <jsoref@gmail.com>

* chore: Try to make CodeQL happy

Signed-off-by: Josh Soref <jsoref@gmail.com>

---------

Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (#20174)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@32945a3...4f58ea7)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): make name property for repos (#20077)

* name-option-added

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

* lint

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

---------

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: basic e2e tests in order to verify notification service health (#20182)

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: document credentials server (#20078)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: Add nodeSelector for Linux nodes (#20148)

* feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor : Reversal the wrong part and correct it.

Signed-off-by: leehosu <hosu4549@gmail.com>

* Update argocd-application-controller-statefulset.yaml

Signed-off-by: l2h <hosu4549@gmail.com>

* feat: Add nodeSelector for Linux nodes in dex-server, argo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for intergration test

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for codegen

Signed-off-by: leehosu <hosu4549@gmail.com>

* Run make manifests-local and then commit

Signed-off-by: leehosu <hosu4549@gmail.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump github.com/cyphar/filepath-securejoin (#20173)

Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.2 to 0.3.3.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases)
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md)
- [Commits](cyphar/filepath-securejoin@v0.3.2...v0.3.3)

---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): parameterize requeue time #20063 (#20064)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): better handling of Go and Node dependency bumps (#20168)

* chore(ci): better handling of Go and Node dependency bumps

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

temporarily remove condition

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

quit early if there are no changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use latest checkout action and actually test version change

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use github token

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

workflow for node

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

clean up after changing node version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

revert temporary changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

more docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* bump linter version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump codecov/codecov-action from 4.5.0 to 4.6.0 (#20188)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@e28ff12...b9fd7d1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs(ui): sorting version (#20181)

Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add outpost24 to users.md (#20197)

Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Update argocd path for command in notifification in troubleshooting docs (#20120)

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump google.golang.org/grpc from 1.67.0 to 1.67.1 (#20190)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.0 to 1.67.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.67.0...v1.67.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump chromedriver from 129.0.0 to 129.0.2 in /ui-test (#20189)

Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 129.0.0 to 129.0.2.
- [Commits](giggio/node-chromedriver@129.0.0...129.0.2)

---
updated-dependencies:
- dependency-name: chromedriver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump bitnami/kubectl in /test/container (#20191)

Bumps bitnami/kubectl from `da4a986` to `b509ab6`.

---
updated-dependencies:
- dependency-name: bitnami/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump library/busybox in /test/e2e/multiarch-container (#20193)

Bumps library/busybox from `c230832` to `768e5c6`.

---
updated-dependencies:
- dependency-name: library/busybox
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(helm): escape consecutive commas in cleanSetParameters (#19269) (#20113)

Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update troubleshooting-errors.md (#20201)

Fixing some phrasing and adding more clarity.

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Rework git tag semver resolution (#20083) (#20096)

* Write initial tests

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Improve git tag semver resolution

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add company to list of users

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix broken error string check

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix incorrect semver test assumption

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* switch to debug statement

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add more testcases for review

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* review comments

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

---------

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (#20207)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): support auto theme (#20080)

* feat(theme): support auto theme

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): set default theme as light

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): only register listener when theme is auto

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

---------

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump selenium-webdriver from 4.24.1 to 4.25.0 in /ui-test (#20058)

Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.1 to 4.25.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.25.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: refine deny destination checks (#20045)

* fix: refine server deny check

Fixes #19804. The deny destination check can be made more intuitive by
doing the following:

* short-circuit any deny destination
* first, for any deny server destination, _also_ check if the namespace matches
* for any deny namespace destination, reject as before

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: also assert that server matches on ns deny

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Added unit tests and fix e2e tests for application sync decoupling feature (#19966)

* fixed doc comments and added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added comments for the newly added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Refactored method name to deriveServiceAccountToImpersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Using const name in return value

Signed-off-by: anandf <anjoseph@redhat.com>

* Added unit tests for argocd proj add-destination-service-accounts

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing e2e tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Fix linting errors

Signed-off-by: anandf <anjoseph@redhat.com>

* Using require package instead of assert and fixed code generation

Signed-off-by: anandf <anjoseph@redhat.com>

* Removed parallel execution of tests for sync with impersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Added err checks for glob validations

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed e2e tests for sync impersonation

Signed-off-by: anandf <anjoseph@redhat.com>

* Using consistently based expects in E2E tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added more unit tests and fixed go generate

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failed lint errors, unit and e2e test failures

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports linter issue

Signed-off-by: anandf <anjoseph@redhat.com>

* Added code comments and added few missing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added missing unit test for GetDestinationServiceAccounts method

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports formatting with local for project_test.go

Signed-off-by: anandf <anjoseph@redhat.com>

* Corrected typo in a field name additionalObjs

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

---------

Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix false positive in plugin application discovery (#20196)

* fix: fix false positive in plugin application discovery

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: update health check to support modelmesh (#20142)

Signed-off-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: rename protobuf field according to convention (#20221)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add TBC Bank to USERS.md (#20227)

* docs: add TBC Bank to USERS.md

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

* docs: reorder TBC Bank by alphabetical

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

---------

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (#20224)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@988b5a0...8026d2b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump tj-actions/changed-files from 45.0.2 to 45.0.3 (#20225)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@48d8f15...c3a1bb2)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: use `ErrorContains(t, err` instead of `Contains(t, err.Error()` (#20220)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Correct ApplicationSet (spec.preservedFields) (#20206)

* Fix docs

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Remove another errant block; improved comments

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Actually removed the errant block

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More doc fixes

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More spec fixes + USERS

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

---------

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(health): only consider non-empty health checks (#20232)

* fix(health): only consider non-empty health checks

For wildcard health checks, only consider wildcards with a non-empty
health check. Fixes #16905 (at least partially).

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: renaming test case for clarity

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* refactor: add clarity as to what the function is supposed to do

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/operator-manual/health.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: add test case for `*/*` override with empty healthcheck

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: support managing cluster with multiple argocd instances and annotation based tracking (#20222)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix notification-catlog issue (#20237)

Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): add renovate for golangci-lint, go and node version (#20236)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump actions/cache from 4.0.2 to 4.1.0 (#20240)

Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0c45773...2cdf405)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.7.0 to 3.7.1 (#20241)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.0 to 3.7.1.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@8026d2b...c47758b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/time from 0.6.0 to 0.7.0 (#20244)

Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0.
- [Commits](golang/time@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(cli): Add app diff option to specify exit code when diff (#20144)

The argocd app diff command returns 1 if a difference is found. In related issues,
they want to return an error code that is distinguishable from common errors.
However, changing the existing behavior is likely to break user's automation code.
So we want to provide an explicit option(--diff-exit-code) to specify an error code.

Related: #3588

Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: add support for helm skipTests flag (#20118)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump sigstore/cosign-installer from 3.6.0 to 3.7.0 (#20242)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@4959ce0...dc72c7d)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 (#20245)

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.24.0 to 0.25.0.
- [Commits](golang/term@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (#20243)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0.
- [Commits](golang/crypto@v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/net from 0.29.0 to 0.30.0 (#20246)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.30.0.
- [Commits](golang/net@v0.29.0...v0.30.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: update notifications-engine to 22ccfe0caf45 (#20239)

* Update notifications-engine

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* Update docs for Opsgenie notifications

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* docs: Fix outdated slack notification configuration readme

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

---------

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (#20250)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: handle incorrect cluster RESTconfig without panic (#20150)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update node version (#20248)

* chore(deps): update node version

* Update ui/.nvmrc

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* sec: update alpine/helm to 3.16.1 (#20253)

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): update renovate config (#20254)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Policy/policy.open-cluster-management.io health check is broken (#20108) (#20109)

Tried using the health check as listed here but it gave error:

| error setting app health: failed to get resource health for "Policy" with name "XXXX" in namespace "local-cluster": <string>:35: invalid value (nil) at index 1 in table for concat stack traceback: [G]: in function 'concat' <string>:35: in main chunk [G]: ?

This change fixes the error by updating how the noncompliant clusters are tracked and counted to use latest Lua recommendations.

Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(applicationset): Add FlatList option to cluster generator - Fixes #20212 (#20231)

* (feat) - Add FlatList option to cluster generator

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>

* Update docs/operator-manual/applicationset/Generators-Cluster.md

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update docs dependencies (#20257)

* chore(deps): update docs dependencies

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump rtd python version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update group golang to v1.23.2 (#20256)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: bump k8s versions in e2e tests (#19669)

Signed-off-by: Moleus <fafufuburr@gmail.com>

---------

Signed-off-by: Moleus <fafufuburr@gmail.com>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: CI <ci@argoproj.com>
Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Trevor Royer <troyer@redhat.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Symeon Meichanetzoglou <sym@open.ch>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Co-authored-by: Tony Au-Yeung <tonyay163@gmail.com>
Co-authored-by: aria <pradithya.pura@gojek.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CI <ci@argoproj.com>
Co-authored-by: Dillen Padhiar <38965141+dpadhiar@users.noreply.github.com>
Co-authored-by: Daco <dacofr@users.noreply.github.com>
Co-authored-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Co-authored-by: ABBOUD Moncef <moncef.abboud95@gmail.com>
Co-authored-by: appiepollo14 <asjer94@live.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Suraj yadav <harrypotter1108@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: l2h <hosu4549@gmail.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: 1102 <90682513+nueavv@users.noreply.github.com>
Co-authored-by: Phong Do <dominhphong306@gmail.com>
Co-authored-by: Olivier Wenger <14903492+owngr@users.noreply.github.com>
Co-authored-by: KangManJoo <eogns47@konkuk.ac.kr>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: Paul Larsen <pnvlarsen@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Anand Francis Joseph <anjoseph@redhat.com>
Co-authored-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mate Gogiberidze <101423812+mategogiberidze@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Jeff Youngs <jyoungs@bluenightmare.com>
Co-authored-by: Ajinkya Ganesh Kumbhar <ajinkyakumbhar423@gmail.com>
Co-authored-by: Julio <juligonz@student.42.fr>
Co-authored-by: Eugene Kim <eugene70kim@gmail.com>
Co-authored-by: 변재한 <awbrg789@naver.com>
Co-authored-by: SLASHLogin <loginmlgxd@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ian Tewksbury <itewk@redhat.com>
Co-authored-by: OpenGuidou <73480729+OpenGuidou@users.noreply.github.com>
ali-hamza-noor pushed a commit to ali-hamza-noor/argo-cd that referenced this pull request Oct 10, 2024
…argoproj#20085)

* docs: Add `404 Not Found` github notification error to troubleshooting docs

Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by upgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087)

Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps-dev): bump @types/node from 22.5.5 to 22.7.2 in /ui-test (argoproj#20112)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.5 to 22.7.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(extension): add header to support apps-in-any-namespace (argoproj#20123)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fix typo (argoproj#20127)

Remove a redundant "is".

Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): add optional check to avoid undefined reference in project detail (argoproj#20044)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump Helm from 3.15.2 to 3.15.4 (argoproj#20135)

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: oras-go client should fallback to docker config if no credentials specified (argoproj#18133)

* oras-go client should fallback to docker config if no credentials specified

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix tests

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix lint

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* gofumpt

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Validate auth header

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

---------

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (argoproj#20154)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.7.0 to 6.8.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@5cd11c3...32945a3)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix argocd appset generate failure due to missing clusterrole (argoproj#20162)

* fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: update generated code

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (argoproj#20146)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: repo generate paths value in namespace install is incorrectly formatted (argoproj#20139)

* Fix repo generate paths value in namespace install

Signed-off-by: todaywasawesome <dan@codefresh.io>

* Fix in base and regen

Signed-off-by: todaywasawesome <dan@codefresh.io>

---------

Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: introduce pause/unpause actions for Numaplane CRDs (argoproj#20128)

* feat: introduce pause/unpause actions for Numaplane CRDs

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: fixed incorrect file names

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: codegen

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: empty check for lifecycle

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil check

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil checks

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: testing different starting spec

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* feat: add nil checks for all possible nil fields

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: rerun tests

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

---------

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation (argoproj#18703)

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Use local client rather than custom cache

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Clean go.mod

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Merge master

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix after merging master
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Initialize appProject variable inside loop

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Remove unused ArgoAppClientset field
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix linter issue
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

---------

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: added note re. arch of example application on getting_started.md (argoproj#20143)

added warning that example application may not run on all archs

Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): hide resource actions menu if it's empty (argoproj#20051)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fixes minor typo which lead to using the bearer token as api URL and was obviously not working. (argoproj#20169)

Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Try to make CodeQL happy (argoproj#20094) (argoproj#20129)

* chore(common): Split const from unrelated util/clusterauth const

Signed-off-by: Josh Soref <jsoref@gmail.com>

* chore: Try to make CodeQL happy

Signed-off-by: Josh Soref <jsoref@gmail.com>

---------

Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (argoproj#20174)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@32945a3...4f58ea7)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): make name property for repos (argoproj#20077)

* name-option-added

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

* lint

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

---------

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: basic e2e tests in order to verify notification service health (argoproj#20182)

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: document credentials server (argoproj#20078)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: Add nodeSelector for Linux nodes (argoproj#20148)

* feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor : Reversal the wrong part and correct it.

Signed-off-by: leehosu <hosu4549@gmail.com>

* Update argocd-application-controller-statefulset.yaml

Signed-off-by: l2h <hosu4549@gmail.com>

* feat: Add nodeSelector for Linux nodes in dex-server, argo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for intergration test

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for codegen

Signed-off-by: leehosu <hosu4549@gmail.com>

* Run make manifests-local and then commit

Signed-off-by: leehosu <hosu4549@gmail.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump github.com/cyphar/filepath-securejoin (argoproj#20173)

Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.2 to 0.3.3.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases)
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md)
- [Commits](cyphar/filepath-securejoin@v0.3.2...v0.3.3)

---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): parameterize requeue time argoproj#20063 (argoproj#20064)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): better handling of Go and Node dependency bumps (argoproj#20168)

* chore(ci): better handling of Go and Node dependency bumps

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

temporarily remove condition

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

quit early if there are no changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use latest checkout action and actually test version change

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use github token

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

workflow for node

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

clean up after changing node version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

revert temporary changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

more docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* bump linter version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump codecov/codecov-action from 4.5.0 to 4.6.0 (argoproj#20188)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@e28ff12...b9fd7d1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs(ui): sorting version (argoproj#20181)

Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add outpost24 to users.md (argoproj#20197)

Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Update argocd path for command in notifification in troubleshooting docs (argoproj#20120)

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump google.golang.org/grpc from 1.67.0 to 1.67.1 (argoproj#20190)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.0 to 1.67.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.67.0...v1.67.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump chromedriver from 129.0.0 to 129.0.2 in /ui-test (argoproj#20189)

Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 129.0.0 to 129.0.2.
- [Commits](giggio/node-chromedriver@129.0.0...129.0.2)

---
updated-dependencies:
- dependency-name: chromedriver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump bitnami/kubectl in /test/container (argoproj#20191)

Bumps bitnami/kubectl from `da4a986` to `b509ab6`.

---
updated-dependencies:
- dependency-name: bitnami/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump library/busybox in /test/e2e/multiarch-container (argoproj#20193)

Bumps library/busybox from `c230832` to `768e5c6`.

---
updated-dependencies:
- dependency-name: library/busybox
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(helm): escape consecutive commas in cleanSetParameters (argoproj#19269) (argoproj#20113)

Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update troubleshooting-errors.md (argoproj#20201)

Fixing some phrasing and adding more clarity.

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Rework git tag semver resolution (argoproj#20083) (argoproj#20096)

* Write initial tests

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Improve git tag semver resolution

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add company to list of users

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix broken error string check

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix incorrect semver test assumption

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* switch to debug statement

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add more testcases for review

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* review comments

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

---------

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (argoproj#20207)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): support auto theme (argoproj#20080)

* feat(theme): support auto theme

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): set default theme as light

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): only register listener when theme is auto

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

---------

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump selenium-webdriver from 4.24.1 to 4.25.0 in /ui-test (argoproj#20058)

Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.1 to 4.25.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.25.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: refine deny destination checks (argoproj#20045)

* fix: refine server deny check

Fixes argoproj#19804. The deny destination check can be made more intuitive by
doing the following:

* short-circuit any deny destination
* first, for any deny server destination, _also_ check if the namespace matches
* for any deny namespace destination, reject as before

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: also assert that server matches on ns deny

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Added unit tests and fix e2e tests for application sync decoupling feature (argoproj#19966)

* fixed doc comments and added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added comments for the newly added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Refactored method name to deriveServiceAccountToImpersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Using const name in return value

Signed-off-by: anandf <anjoseph@redhat.com>

* Added unit tests for argocd proj add-destination-service-accounts

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing e2e tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Fix linting errors

Signed-off-by: anandf <anjoseph@redhat.com>

* Using require package instead of assert and fixed code generation

Signed-off-by: anandf <anjoseph@redhat.com>

* Removed parallel execution of tests for sync with impersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Added err checks for glob validations

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed e2e tests for sync impersonation

Signed-off-by: anandf <anjoseph@redhat.com>

* Using consistently based expects in E2E tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added more unit tests and fixed go generate

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failed lint errors, unit and e2e test failures

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports linter issue

Signed-off-by: anandf <anjoseph@redhat.com>

* Added code comments and added few missing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added missing unit test for GetDestinationServiceAccounts method

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports formatting with local for project_test.go

Signed-off-by: anandf <anjoseph@redhat.com>

* Corrected typo in a field name additionalObjs

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

---------

Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix false positive in plugin application discovery (argoproj#20196)

* fix: fix false positive in plugin application discovery

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: update health check to support modelmesh (argoproj#20142)

Signed-off-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: rename protobuf field according to convention (argoproj#20221)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add TBC Bank to USERS.md (argoproj#20227)

* docs: add TBC Bank to USERS.md

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

* docs: reorder TBC Bank by alphabetical

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

---------

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (argoproj#20224)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@988b5a0...8026d2b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump tj-actions/changed-files from 45.0.2 to 45.0.3 (argoproj#20225)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@48d8f15...c3a1bb2)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: use `ErrorContains(t, err` instead of `Contains(t, err.Error()` (argoproj#20220)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Correct ApplicationSet (spec.preservedFields) (argoproj#20206)

* Fix docs

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Remove another errant block; improved comments

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Actually removed the errant block

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More doc fixes

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More spec fixes + USERS

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

---------

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(health): only consider non-empty health checks (argoproj#20232)

* fix(health): only consider non-empty health checks

For wildcard health checks, only consider wildcards with a non-empty
health check. Fixes argoproj#16905 (at least partially).

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: renaming test case for clarity

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* refactor: add clarity as to what the function is supposed to do

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/operator-manual/health.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: add test case for `*/*` override with empty healthcheck

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: support managing cluster with multiple argocd instances and annotation based tracking (argoproj#20222)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix notification-catlog issue (argoproj#20237)

Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): add renovate for golangci-lint, go and node version (argoproj#20236)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump actions/cache from 4.0.2 to 4.1.0 (argoproj#20240)

Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0c45773...2cdf405)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.7.0 to 3.7.1 (argoproj#20241)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.0 to 3.7.1.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@8026d2b...c47758b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/time from 0.6.0 to 0.7.0 (argoproj#20244)

Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0.
- [Commits](golang/time@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(cli): Add app diff option to specify exit code when diff (argoproj#20144)

The argocd app diff command returns 1 if a difference is found. In related issues,
they want to return an error code that is distinguishable from common errors.
However, changing the existing behavior is likely to break user's automation code.
So we want to provide an explicit option(--diff-exit-code) to specify an error code.

Related: argoproj#3588

Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: add support for helm skipTests flag (argoproj#20118)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump sigstore/cosign-installer from 3.6.0 to 3.7.0 (argoproj#20242)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@4959ce0...dc72c7d)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 (argoproj#20245)

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.24.0 to 0.25.0.
- [Commits](golang/term@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (argoproj#20243)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0.
- [Commits](golang/crypto@v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/net from 0.29.0 to 0.30.0 (argoproj#20246)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.30.0.
- [Commits](golang/net@v0.29.0...v0.30.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: update notifications-engine to 22ccfe0caf45 (argoproj#20239)

* Update notifications-engine

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* Update docs for Opsgenie notifications

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* docs: Fix outdated slack notification configuration readme

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

---------

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (argoproj#20250)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: handle incorrect cluster RESTconfig without panic (argoproj#20150)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update node version (argoproj#20248)

* chore(deps): update node version

* Update ui/.nvmrc

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* sec: update alpine/helm to 3.16.1 (argoproj#20253)

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): update renovate config (argoproj#20254)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Policy/policy.open-cluster-management.io health check is broken (argoproj#20108) (argoproj#20109)

Tried using the health check as listed here but it gave error:

| error setting app health: failed to get resource health for "Policy" with name "XXXX" in namespace "local-cluster": <string>:35: invalid value (nil) at index 1 in table for concat stack traceback: [G]: in function 'concat' <string>:35: in main chunk [G]: ?

This change fixes the error by updating how the noncompliant clusters are tracked and counted to use latest Lua recommendations.

Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(applicationset): Add FlatList option to cluster generator - Fixes argoproj#20212 (argoproj#20231)

* (feat) - Add FlatList option to cluster generator

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>

* Update docs/operator-manual/applicationset/Generators-Cluster.md

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update docs dependencies (argoproj#20257)

* chore(deps): update docs dependencies

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump rtd python version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update group golang to v1.23.2 (argoproj#20256)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: bump k8s versions in e2e tests (argoproj#19669)

Signed-off-by: Moleus <fafufuburr@gmail.com>

---------

Signed-off-by: Moleus <fafufuburr@gmail.com>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: CI <ci@argoproj.com>
Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Trevor Royer <troyer@redhat.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Symeon Meichanetzoglou <sym@open.ch>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Co-authored-by: Tony Au-Yeung <tonyay163@gmail.com>
Co-authored-by: aria <pradithya.pura@gojek.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CI <ci@argoproj.com>
Co-authored-by: Dillen Padhiar <38965141+dpadhiar@users.noreply.github.com>
Co-authored-by: Daco <dacofr@users.noreply.github.com>
Co-authored-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Co-authored-by: ABBOUD Moncef <moncef.abboud95@gmail.com>
Co-authored-by: appiepollo14 <asjer94@live.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Suraj yadav <harrypotter1108@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: l2h <hosu4549@gmail.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: 1102 <90682513+nueavv@users.noreply.github.com>
Co-authored-by: Phong Do <dominhphong306@gmail.com>
Co-authored-by: Olivier Wenger <14903492+owngr@users.noreply.github.com>
Co-authored-by: KangManJoo <eogns47@konkuk.ac.kr>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: Paul Larsen <pnvlarsen@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Anand Francis Joseph <anjoseph@redhat.com>
Co-authored-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mate Gogiberidze <101423812+mategogiberidze@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Jeff Youngs <jyoungs@bluenightmare.com>
Co-authored-by: Ajinkya Ganesh Kumbhar <ajinkyakumbhar423@gmail.com>
Co-authored-by: Julio <juligonz@student.42.fr>
Co-authored-by: Eugene Kim <eugene70kim@gmail.com>
Co-authored-by: 변재한 <awbrg789@naver.com>
Co-authored-by: SLASHLogin <loginmlgxd@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ian Tewksbury <itewk@redhat.com>
Co-authored-by: OpenGuidou <73480729+OpenGuidou@users.noreply.github.com>
Signed-off-by: alnoor <alihamzanoor99@gmail.com>
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
* feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor : Reversal the wrong part and correct it.

Signed-off-by: leehosu <hosu4549@gmail.com>

* Update argocd-application-controller-statefulset.yaml

Signed-off-by: l2h <hosu4549@gmail.com>

* feat: Add nodeSelector for Linux nodes in dex-server, argo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for intergration test

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for codegen

Signed-off-by: leehosu <hosu4549@gmail.com>

* Run make manifests-local and then commit

Signed-off-by: leehosu <hosu4549@gmail.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
…argoproj#20085)

* docs: Add `404 Not Found` github notification error to troubleshooting docs

Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by upgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087)

Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps-dev): bump @types/node from 22.5.5 to 22.7.2 in /ui-test (argoproj#20112)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.5 to 22.7.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(extension): add header to support apps-in-any-namespace (argoproj#20123)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fix typo (argoproj#20127)

Remove a redundant "is".

Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): add optional check to avoid undefined reference in project detail (argoproj#20044)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump Helm from 3.15.2 to 3.15.4 (argoproj#20135)

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: oras-go client should fallback to docker config if no credentials specified (argoproj#18133)

* oras-go client should fallback to docker config if no credentials specified

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix tests

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix lint

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* gofumpt

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Validate auth header

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

---------

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (argoproj#20154)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.7.0 to 6.8.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@5cd11c3...32945a3)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix argocd appset generate failure due to missing clusterrole (argoproj#20162)

* fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: update generated code

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (argoproj#20146)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: repo generate paths value in namespace install is incorrectly formatted (argoproj#20139)

* Fix repo generate paths value in namespace install

Signed-off-by: todaywasawesome <dan@codefresh.io>

* Fix in base and regen

Signed-off-by: todaywasawesome <dan@codefresh.io>

---------

Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: introduce pause/unpause actions for Numaplane CRDs (argoproj#20128)

* feat: introduce pause/unpause actions for Numaplane CRDs

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: fixed incorrect file names

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: codegen

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: empty check for lifecycle

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil check

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil checks

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: testing different starting spec

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* feat: add nil checks for all possible nil fields

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: rerun tests

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

---------

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation (argoproj#18703)

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Use local client rather than custom cache

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Clean go.mod

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Merge master

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix after merging master
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Initialize appProject variable inside loop

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Remove unused ArgoAppClientset field
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix linter issue
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

---------

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: added note re. arch of example application on getting_started.md (argoproj#20143)

added warning that example application may not run on all archs

Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): hide resource actions menu if it's empty (argoproj#20051)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fixes minor typo which lead to using the bearer token as api URL and was obviously not working. (argoproj#20169)

Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Try to make CodeQL happy (argoproj#20094) (argoproj#20129)

* chore(common): Split const from unrelated util/clusterauth const

Signed-off-by: Josh Soref <jsoref@gmail.com>

* chore: Try to make CodeQL happy

Signed-off-by: Josh Soref <jsoref@gmail.com>

---------

Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (argoproj#20174)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@32945a3...4f58ea7)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): make name property for repos (argoproj#20077)

* name-option-added

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

* lint

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

---------

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: basic e2e tests in order to verify notification service health (argoproj#20182)

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: document credentials server (argoproj#20078)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: Add nodeSelector for Linux nodes (argoproj#20148)

* feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor : Reversal the wrong part and correct it.

Signed-off-by: leehosu <hosu4549@gmail.com>

* Update argocd-application-controller-statefulset.yaml

Signed-off-by: l2h <hosu4549@gmail.com>

* feat: Add nodeSelector for Linux nodes in dex-server, argo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for intergration test

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for codegen

Signed-off-by: leehosu <hosu4549@gmail.com>

* Run make manifests-local and then commit

Signed-off-by: leehosu <hosu4549@gmail.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump github.com/cyphar/filepath-securejoin (argoproj#20173)

Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.2 to 0.3.3.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases)
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md)
- [Commits](cyphar/filepath-securejoin@v0.3.2...v0.3.3)

---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): parameterize requeue time argoproj#20063 (argoproj#20064)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): better handling of Go and Node dependency bumps (argoproj#20168)

* chore(ci): better handling of Go and Node dependency bumps

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

temporarily remove condition

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

quit early if there are no changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use latest checkout action and actually test version change

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use github token

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

workflow for node

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

clean up after changing node version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

revert temporary changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

more docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* bump linter version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump codecov/codecov-action from 4.5.0 to 4.6.0 (argoproj#20188)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@e28ff12...b9fd7d1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs(ui): sorting version (argoproj#20181)

Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add outpost24 to users.md (argoproj#20197)

Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Update argocd path for command in notifification in troubleshooting docs (argoproj#20120)

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump google.golang.org/grpc from 1.67.0 to 1.67.1 (argoproj#20190)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.0 to 1.67.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.67.0...v1.67.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump chromedriver from 129.0.0 to 129.0.2 in /ui-test (argoproj#20189)

Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 129.0.0 to 129.0.2.
- [Commits](giggio/node-chromedriver@129.0.0...129.0.2)

---
updated-dependencies:
- dependency-name: chromedriver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump bitnami/kubectl in /test/container (argoproj#20191)

Bumps bitnami/kubectl from `da4a986` to `b509ab6`.

---
updated-dependencies:
- dependency-name: bitnami/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump library/busybox in /test/e2e/multiarch-container (argoproj#20193)

Bumps library/busybox from `c230832` to `768e5c6`.

---
updated-dependencies:
- dependency-name: library/busybox
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(helm): escape consecutive commas in cleanSetParameters (argoproj#19269) (argoproj#20113)

Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update troubleshooting-errors.md (argoproj#20201)

Fixing some phrasing and adding more clarity.

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Rework git tag semver resolution (argoproj#20083) (argoproj#20096)

* Write initial tests

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Improve git tag semver resolution

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add company to list of users

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix broken error string check

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix incorrect semver test assumption

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* switch to debug statement

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add more testcases for review

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* review comments

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

---------

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (argoproj#20207)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): support auto theme (argoproj#20080)

* feat(theme): support auto theme

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): set default theme as light

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): only register listener when theme is auto

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

---------

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump selenium-webdriver from 4.24.1 to 4.25.0 in /ui-test (argoproj#20058)

Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.1 to 4.25.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.25.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: refine deny destination checks (argoproj#20045)

* fix: refine server deny check

Fixes argoproj#19804. The deny destination check can be made more intuitive by
doing the following:

* short-circuit any deny destination
* first, for any deny server destination, _also_ check if the namespace matches
* for any deny namespace destination, reject as before

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: also assert that server matches on ns deny

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Added unit tests and fix e2e tests for application sync decoupling feature (argoproj#19966)

* fixed doc comments and added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added comments for the newly added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Refactored method name to deriveServiceAccountToImpersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Using const name in return value

Signed-off-by: anandf <anjoseph@redhat.com>

* Added unit tests for argocd proj add-destination-service-accounts

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing e2e tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Fix linting errors

Signed-off-by: anandf <anjoseph@redhat.com>

* Using require package instead of assert and fixed code generation

Signed-off-by: anandf <anjoseph@redhat.com>

* Removed parallel execution of tests for sync with impersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Added err checks for glob validations

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed e2e tests for sync impersonation

Signed-off-by: anandf <anjoseph@redhat.com>

* Using consistently based expects in E2E tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added more unit tests and fixed go generate

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failed lint errors, unit and e2e test failures

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports linter issue

Signed-off-by: anandf <anjoseph@redhat.com>

* Added code comments and added few missing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added missing unit test for GetDestinationServiceAccounts method

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports formatting with local for project_test.go

Signed-off-by: anandf <anjoseph@redhat.com>

* Corrected typo in a field name additionalObjs

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

---------

Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix false positive in plugin application discovery (argoproj#20196)

* fix: fix false positive in plugin application discovery

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: update health check to support modelmesh (argoproj#20142)

Signed-off-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: rename protobuf field according to convention (argoproj#20221)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add TBC Bank to USERS.md (argoproj#20227)

* docs: add TBC Bank to USERS.md

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

* docs: reorder TBC Bank by alphabetical

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

---------

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (argoproj#20224)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@988b5a0...8026d2b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump tj-actions/changed-files from 45.0.2 to 45.0.3 (argoproj#20225)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@48d8f15...c3a1bb2)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: use `ErrorContains(t, err` instead of `Contains(t, err.Error()` (argoproj#20220)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Correct ApplicationSet (spec.preservedFields) (argoproj#20206)

* Fix docs

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Remove another errant block; improved comments

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Actually removed the errant block

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More doc fixes

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More spec fixes + USERS

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

---------

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(health): only consider non-empty health checks (argoproj#20232)

* fix(health): only consider non-empty health checks

For wildcard health checks, only consider wildcards with a non-empty
health check. Fixes argoproj#16905 (at least partially).

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: renaming test case for clarity

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* refactor: add clarity as to what the function is supposed to do

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/operator-manual/health.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: add test case for `*/*` override with empty healthcheck

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: support managing cluster with multiple argocd instances and annotation based tracking (argoproj#20222)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix notification-catlog issue (argoproj#20237)

Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): add renovate for golangci-lint, go and node version (argoproj#20236)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump actions/cache from 4.0.2 to 4.1.0 (argoproj#20240)

Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0c45773...2cdf405)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.7.0 to 3.7.1 (argoproj#20241)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.0 to 3.7.1.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@8026d2b...c47758b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/time from 0.6.0 to 0.7.0 (argoproj#20244)

Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0.
- [Commits](golang/time@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(cli): Add app diff option to specify exit code when diff (argoproj#20144)

The argocd app diff command returns 1 if a difference is found. In related issues,
they want to return an error code that is distinguishable from common errors.
However, changing the existing behavior is likely to break user's automation code.
So we want to provide an explicit option(--diff-exit-code) to specify an error code.

Related: argoproj#3588

Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: add support for helm skipTests flag (argoproj#20118)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump sigstore/cosign-installer from 3.6.0 to 3.7.0 (argoproj#20242)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@4959ce0...dc72c7d)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 (argoproj#20245)

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.24.0 to 0.25.0.
- [Commits](golang/term@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (argoproj#20243)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0.
- [Commits](golang/crypto@v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/net from 0.29.0 to 0.30.0 (argoproj#20246)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.30.0.
- [Commits](golang/net@v0.29.0...v0.30.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: update notifications-engine to 22ccfe0caf45 (argoproj#20239)

* Update notifications-engine

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* Update docs for Opsgenie notifications

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* docs: Fix outdated slack notification configuration readme

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

---------

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (argoproj#20250)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: handle incorrect cluster RESTconfig without panic (argoproj#20150)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update node version (argoproj#20248)

* chore(deps): update node version

* Update ui/.nvmrc

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* sec: update alpine/helm to 3.16.1 (argoproj#20253)

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): update renovate config (argoproj#20254)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Policy/policy.open-cluster-management.io health check is broken (argoproj#20108) (argoproj#20109)

Tried using the health check as listed here but it gave error:

| error setting app health: failed to get resource health for "Policy" with name "XXXX" in namespace "local-cluster": <string>:35: invalid value (nil) at index 1 in table for concat stack traceback: [G]: in function 'concat' <string>:35: in main chunk [G]: ?

This change fixes the error by updating how the noncompliant clusters are tracked and counted to use latest Lua recommendations.

Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(applicationset): Add FlatList option to cluster generator - Fixes argoproj#20212 (argoproj#20231)

* (feat) - Add FlatList option to cluster generator

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>

* Update docs/operator-manual/applicationset/Generators-Cluster.md

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update docs dependencies (argoproj#20257)

* chore(deps): update docs dependencies

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump rtd python version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update group golang to v1.23.2 (argoproj#20256)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: bump k8s versions in e2e tests (argoproj#19669)

Signed-off-by: Moleus <fafufuburr@gmail.com>

---------

Signed-off-by: Moleus <fafufuburr@gmail.com>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: CI <ci@argoproj.com>
Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Trevor Royer <troyer@redhat.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Symeon Meichanetzoglou <sym@open.ch>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Co-authored-by: Tony Au-Yeung <tonyay163@gmail.com>
Co-authored-by: aria <pradithya.pura@gojek.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CI <ci@argoproj.com>
Co-authored-by: Dillen Padhiar <38965141+dpadhiar@users.noreply.github.com>
Co-authored-by: Daco <dacofr@users.noreply.github.com>
Co-authored-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Co-authored-by: ABBOUD Moncef <moncef.abboud95@gmail.com>
Co-authored-by: appiepollo14 <asjer94@live.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Suraj yadav <harrypotter1108@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: l2h <hosu4549@gmail.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: 1102 <90682513+nueavv@users.noreply.github.com>
Co-authored-by: Phong Do <dominhphong306@gmail.com>
Co-authored-by: Olivier Wenger <14903492+owngr@users.noreply.github.com>
Co-authored-by: KangManJoo <eogns47@konkuk.ac.kr>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: Paul Larsen <pnvlarsen@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Anand Francis Joseph <anjoseph@redhat.com>
Co-authored-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mate Gogiberidze <101423812+mategogiberidze@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Jeff Youngs <jyoungs@bluenightmare.com>
Co-authored-by: Ajinkya Ganesh Kumbhar <ajinkyakumbhar423@gmail.com>
Co-authored-by: Julio <juligonz@student.42.fr>
Co-authored-by: Eugene Kim <eugene70kim@gmail.com>
Co-authored-by: 변재한 <awbrg789@naver.com>
Co-authored-by: SLASHLogin <loginmlgxd@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ian Tewksbury <itewk@redhat.com>
Co-authored-by: OpenGuidou <73480729+OpenGuidou@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
* feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor : Reversal the wrong part and correct it.

Signed-off-by: leehosu <hosu4549@gmail.com>

* Update argocd-application-controller-statefulset.yaml

Signed-off-by: l2h <hosu4549@gmail.com>

* feat: Add nodeSelector for Linux nodes in dex-server, argo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for intergration test

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for codegen

Signed-off-by: leehosu <hosu4549@gmail.com>

* Run make manifests-local and then commit

Signed-off-by: leehosu <hosu4549@gmail.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…argoproj#20085)

* docs: Add `404 Not Found` github notification error to troubleshooting docs

Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update docs/operator-manual/notifications/troubleshooting-errors.md

Signed-off-by: Dan Garfield <dan@codefresh.io>

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by upgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087)

Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps-dev): bump @types/node from 22.5.5 to 22.7.2 in /ui-test (argoproj#20112)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.5.5 to 22.7.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(extension): add header to support apps-in-any-namespace (argoproj#20123)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fix typo (argoproj#20127)

Remove a redundant "is".

Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): add optional check to avoid undefined reference in project detail (argoproj#20044)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump Helm from 3.15.2 to 3.15.4 (argoproj#20135)

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* sec: upgrade helm version in order to fix critical vulnerability

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: oras-go client should fallback to docker config if no credentials specified (argoproj#18133)

* oras-go client should fallback to docker config if no credentials specified

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix tests

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Fix lint

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* gofumpt

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

* Validate auth header

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>

---------

Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.7.0 to 6.8.0 (argoproj#20154)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.7.0 to 6.8.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@5cd11c3...32945a3)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix argocd appset generate failure due to missing clusterrole (argoproj#20162)

* fix: FIx argocd-server clusterrole to allow argocd appset generate using cluster generator

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: update generated code

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (argoproj#20146)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: repo generate paths value in namespace install is incorrectly formatted (argoproj#20139)

* Fix repo generate paths value in namespace install

Signed-off-by: todaywasawesome <dan@codefresh.io>

* Fix in base and regen

Signed-off-by: todaywasawesome <dan@codefresh.io>

---------

Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: introduce pause/unpause actions for Numaplane CRDs (argoproj#20128)

* feat: introduce pause/unpause actions for Numaplane CRDs

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: fixed incorrect file names

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: codegen

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: empty check for lifecycle

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil check

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* fix: nil checks

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: testing different starting spec

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* feat: add nil checks for all possible nil fields

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: rerun tests

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

---------

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation (argoproj#18703)

* feat(appset): Add a cache layer for Argo Projects to speed-up application validation

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Use local client rather than custom cache

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Clean go.mod

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Merge master

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix after merging master
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Initialize appProject variable inside loop

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Remove unused ArgoAppClientset field
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

* Fix linter issue
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>

---------

Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: added note re. arch of example application on getting_started.md (argoproj#20143)

added warning that example application may not run on all archs

Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(ui): hide resource actions menu if it's empty (argoproj#20051)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Fixes minor typo which lead to using the bearer token as api URL and was obviously not working. (argoproj#20169)

Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Try to make CodeQL happy (argoproj#20094) (argoproj#20129)

* chore(common): Split const from unrelated util/clusterauth const

Signed-off-by: Josh Soref <jsoref@gmail.com>

* chore: Try to make CodeQL happy

Signed-off-by: Josh Soref <jsoref@gmail.com>

---------

Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 (argoproj#20174)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@32945a3...4f58ea7)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): make name property for repos (argoproj#20077)

* name-option-added

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

* lint

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

---------

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: basic e2e tests in order to verify notification service health (argoproj#20182)

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

* feat: basic e2e tests in order to verify notification service health

Signed-off-by: pashakostohrys <pavel@codefresh.io>

---------

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: document credentials server (argoproj#20078)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: Add nodeSelector for Linux nodes (argoproj#20148)

* feat: Add nodeSelector for Linux nodes in application-controller, applicationset-controller, and repo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor : Reversal the wrong part and correct it.

Signed-off-by: leehosu <hosu4549@gmail.com>

* Update argocd-application-controller-statefulset.yaml

Signed-off-by: l2h <hosu4549@gmail.com>

* feat: Add nodeSelector for Linux nodes in dex-server, argo-server

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for intergration test

Signed-off-by: leehosu <hosu4549@gmail.com>

* refactor: update code to resolving for codegen

Signed-off-by: leehosu <hosu4549@gmail.com>

* Run make manifests-local and then commit

Signed-off-by: leehosu <hosu4549@gmail.com>

---------

Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump github.com/cyphar/filepath-securejoin (argoproj#20173)

Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.2 to 0.3.3.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases)
- [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md)
- [Commits](cyphar/filepath-securejoin@v0.3.2...v0.3.3)

---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(appset): parameterize requeue time argoproj#20063 (argoproj#20064)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): better handling of Go and Node dependency bumps (argoproj#20168)

* chore(ci): better handling of Go and Node dependency bumps

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

temporarily remove condition

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

quit early if there are no changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use latest checkout action and actually test version change

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

use github token

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

workflow for node

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

clean up after changing node version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

revert temporary changes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

more docs

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* bump linter version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump codecov/codecov-action from 4.5.0 to 4.6.0 (argoproj#20188)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@e28ff12...b9fd7d1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs(ui): sorting version (argoproj#20181)

Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add outpost24 to users.md (argoproj#20197)

Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Update argocd path for command in notifification in troubleshooting docs (argoproj#20120)

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump google.golang.org/grpc from 1.67.0 to 1.67.1 (argoproj#20190)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.67.0 to 1.67.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.67.0...v1.67.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump chromedriver from 129.0.0 to 129.0.2 in /ui-test (argoproj#20189)

Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 129.0.0 to 129.0.2.
- [Commits](giggio/node-chromedriver@129.0.0...129.0.2)

---
updated-dependencies:
- dependency-name: chromedriver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump bitnami/kubectl in /test/container (argoproj#20191)

Bumps bitnami/kubectl from `da4a986` to `b509ab6`.

---
updated-dependencies:
- dependency-name: bitnami/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump library/busybox in /test/e2e/multiarch-container (argoproj#20193)

Bumps library/busybox from `c230832` to `768e5c6`.

---
updated-dependencies:
- dependency-name: library/busybox
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(helm): escape consecutive commas in cleanSetParameters (argoproj#19269) (argoproj#20113)

Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* Update troubleshooting-errors.md (argoproj#20201)

Fixing some phrasing and adding more clarity.

Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Rework git tag semver resolution (argoproj#20083) (argoproj#20096)

* Write initial tests

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Improve git tag semver resolution

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add company to list of users

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix broken error string check

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Fix incorrect semver test assumption

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* switch to debug statement

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* Add more testcases for review

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

* review comments

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>

---------

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 (argoproj#20207)

Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(ui): support auto theme (argoproj#20080)

* feat(theme): support auto theme

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): set default theme as light

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

* fix(ui): only register listener when theme is auto

Signed-off-by: linghaoSu <linghao.su@daocloud.io>

---------

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump selenium-webdriver from 4.24.1 to 4.25.0 in /ui-test (argoproj#20058)

Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.24.1 to 4.25.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.25.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: refine deny destination checks (argoproj#20045)

* fix: refine server deny check

Fixes argoproj#19804. The deny destination check can be made more intuitive by
doing the following:

* short-circuit any deny destination
* first, for any deny server destination, _also_ check if the namespace matches
* for any deny namespace destination, reject as before

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* fix: also assert that server matches on ns deny

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: Added unit tests and fix e2e tests for application sync decoupling feature (argoproj#19966)

* fixed doc comments and added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added comments for the newly added unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Refactored method name to deriveServiceAccountToImpersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Using const name in return value

Signed-off-by: anandf <anjoseph@redhat.com>

* Added unit tests for argocd proj add-destination-service-accounts

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing e2e tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Fix linting errors

Signed-off-by: anandf <anjoseph@redhat.com>

* Using require package instead of assert and fixed code generation

Signed-off-by: anandf <anjoseph@redhat.com>

* Removed parallel execution of tests for sync with impersonate

Signed-off-by: anandf <anjoseph@redhat.com>

* Added err checks for glob validations

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed e2e tests for sync impersonation

Signed-off-by: anandf <anjoseph@redhat.com>

* Using consistently based expects in E2E tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added more unit tests and fixed go generate

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failed lint errors, unit and e2e test failures

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports linter issue

Signed-off-by: anandf <anjoseph@redhat.com>

* Added code comments and added few missing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

* Added missing unit test for GetDestinationServiceAccounts method

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed goimports formatting with local for project_test.go

Signed-off-by: anandf <anjoseph@redhat.com>

* Corrected typo in a field name additionalObjs

Signed-off-by: anandf <anjoseph@redhat.com>

* Fixed failing unit tests

Signed-off-by: anandf <anjoseph@redhat.com>

---------

Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Fix false positive in plugin application discovery (argoproj#20196)

* fix: fix false positive in plugin application discovery

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

* fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>

---------

Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: update health check to support modelmesh (argoproj#20142)

Signed-off-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: rename protobuf field according to convention (argoproj#20221)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: add TBC Bank to USERS.md (argoproj#20227)

* docs: add TBC Bank to USERS.md

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

* docs: reorder TBC Bank by alphabetical

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>

---------

Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.6.1 to 3.7.0 (argoproj#20224)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.6.1 to 3.7.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@988b5a0...8026d2b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump tj-actions/changed-files from 45.0.2 to 45.0.3 (argoproj#20225)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45.0.2 to 45.0.3.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@48d8f15...c3a1bb2)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: use `ErrorContains(t, err` instead of `Contains(t, err.Error()` (argoproj#20220)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* docs: Correct ApplicationSet (spec.preservedFields) (argoproj#20206)

* Fix docs

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Remove another errant block; improved comments

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* Actually removed the errant block

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More doc fixes

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

* More spec fixes + USERS

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>

---------

Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix(health): only consider non-empty health checks (argoproj#20232)

* fix(health): only consider non-empty health checks

For wildcard health checks, only consider wildcards with a non-empty
health check. Fixes argoproj#16905 (at least partially).

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: renaming test case for clarity

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* refactor: add clarity as to what the function is supposed to do

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* Update docs/operator-manual/health.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* test: add test case for `*/*` override with empty healthcheck

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: support managing cluster with multiple argocd instances and annotation based tracking (argoproj#20222)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix notification-catlog issue (argoproj#20237)

Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): add renovate for golangci-lint, go and node version (argoproj#20236)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump actions/cache from 4.0.2 to 4.1.0 (argoproj#20240)

Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0c45773...2cdf405)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump docker/setup-buildx-action from 3.7.0 to 3.7.1 (argoproj#20241)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.0 to 3.7.1.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@8026d2b...c47758b)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/time from 0.6.0 to 0.7.0 (argoproj#20244)

Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0.
- [Commits](golang/time@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(cli): Add app diff option to specify exit code when diff (argoproj#20144)

The argocd app diff command returns 1 if a difference is found. In related issues,
they want to return an error code that is distinguishable from common errors.
However, changing the existing behavior is likely to break user's automation code.
So we want to provide an explicit option(--diff-exit-code) to specify an error code.

Related: argoproj#3588

Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat: add support for helm skipTests flag (argoproj#20118)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump sigstore/cosign-installer from 3.6.0 to 3.7.0 (argoproj#20242)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@4959ce0...dc72c7d)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 (argoproj#20245)

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.24.0 to 0.25.0.
- [Commits](golang/term@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (argoproj#20243)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0.
- [Commits](golang/crypto@v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): bump golang.org/x/net from 0.29.0 to 0.30.0 (argoproj#20246)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.30.0.
- [Commits](golang/net@v0.29.0...v0.30.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: update notifications-engine to 22ccfe0caf45 (argoproj#20239)

* Update notifications-engine

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* Update docs for Opsgenie notifications

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

* docs: Fix outdated slack notification configuration readme

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>

---------

Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* [Bot] docs: Update Snyk reports (argoproj#20250)

Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: handle incorrect cluster RESTconfig without panic (argoproj#20150)

Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update node version (argoproj#20248)

* chore(deps): update node version

* Update ui/.nvmrc

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* sec: update alpine/helm to 3.16.1 (argoproj#20253)

Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(ci): update renovate config (argoproj#20254)

Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* fix: Policy/policy.open-cluster-management.io health check is broken (argoproj#20108) (argoproj#20109)

Tried using the health check as listed here but it gave error:

| error setting app health: failed to get resource health for "Policy" with name "XXXX" in namespace "local-cluster": <string>:35: invalid value (nil) at index 1 in table for concat stack traceback: [G]: in function 'concat' <string>:35: in main chunk [G]: ?

This change fixes the error by updating how the noncompliant clusters are tracked and counted to use latest Lua recommendations.

Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* feat(applicationset): Add FlatList option to cluster generator - Fixes argoproj#20212 (argoproj#20231)

* (feat) - Add FlatList option to cluster generator

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>

* Update docs/operator-manual/applicationset/Generators-Cluster.md

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update docs dependencies (argoproj#20257)

* chore(deps): update docs dependencies

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump rtd python version

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore(deps): update group golang to v1.23.2 (argoproj#20256)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Moleus <fafufuburr@gmail.com>

* chore: bump k8s versions in e2e tests (argoproj#19669)

Signed-off-by: Moleus <fafufuburr@gmail.com>

---------

Signed-off-by: Moleus <fafufuburr@gmail.com>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Symeon Meichanetzoglou <simosmeih@gmail.com>
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Tony Au-Yeung <tony@elevenlabs.io>
Signed-off-by: Pradithya Aria <pradithya.pura@gojek.com>
Signed-off-by: CI <ci@argoproj.com>
Signed-off-by: todaywasawesome <dan@codefresh.io>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Philippe Da Costa <pdacosta@gmail.com>
Signed-off-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Signed-off-by: cef <moncef.abboud95@gmail.com>
Signed-off-by: asjervanasten <asjer94@live.com>
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: leehosu <hosu4549@gmail.com>
Signed-off-by: l2h <hosu4549@gmail.com>
Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: Phong Do <dominhphong306@gmail.com>
Signed-off-by: KangManJoo <eogns47@konkuk.ac.kr>
Signed-off-by: daengdaengLee <gunho1020@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Trevor Royer <troyer@redhat.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Mate Gogiberidze <gogiberidzemate9@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: jyoungs <jyoungs@bluenightmare.com>
Signed-off-by: ajinkyak423 <ajinkyakumbhar423@gmail.com>
Signed-off-by: ggjulio <juligonz@student.42.fr>
Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: SLASHLogin <loginmlgxd@gmail.com>
Signed-off-by: Ian Tewksbury <itewk@redhat.com>
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Symeon Meichanetzoglou <sym@open.ch>
Co-authored-by: Linghao Su <linghao.su@daocloud.io>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Co-authored-by: Tony Au-Yeung <tonyay163@gmail.com>
Co-authored-by: aria <pradithya.pura@gojek.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CI <ci@argoproj.com>
Co-authored-by: Dillen Padhiar <38965141+dpadhiar@users.noreply.github.com>
Co-authored-by: Daco <dacofr@users.noreply.github.com>
Co-authored-by: Crumbs <44215646+Crumb5@users.noreply.github.com>
Co-authored-by: ABBOUD Moncef <moncef.abboud95@gmail.com>
Co-authored-by: appiepollo14 <asjer94@live.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Suraj yadav <harrypotter1108@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: l2h <hosu4549@gmail.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: 1102 <90682513+nueavv@users.noreply.github.com>
Co-authored-by: Phong Do <dominhphong306@gmail.com>
Co-authored-by: Olivier Wenger <14903492+owngr@users.noreply.github.com>
Co-authored-by: KangManJoo <eogns47@konkuk.ac.kr>
Co-authored-by: daengdaengLee <gunho1020@gmail.com>
Co-authored-by: Paul Larsen <pnvlarsen@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Anand Francis Joseph <anjoseph@redhat.com>
Co-authored-by: Trevor Royer <troyer@redhat.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Co-authored-by: Mate Gogiberidze <101423812+mategogiberidze@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Jeff Youngs <jyoungs@bluenightmare.com>
Co-authored-by: Ajinkya Ganesh Kumbhar <ajinkyakumbhar423@gmail.com>
Co-authored-by: Julio <juligonz@student.42.fr>
Co-authored-by: Eugene Kim <eugene70kim@gmail.com>
Co-authored-by: 변재한 <awbrg789@naver.com>
Co-authored-by: SLASHLogin <loginmlgxd@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ian Tewksbury <itewk@redhat.com>
Co-authored-by: OpenGuidou <73480729+OpenGuidou@users.noreply.github.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Node Selector for Linux Nodes in Deployment YAML for Hybrid Cluster Support
8 participants