Describe the bug

Pinning to a git tag uses the wrong commit.

To Reproduce

An example app to reproduce this is available here: https://github.com/PaulSonOfLars/test-argo-app

Note that the repo has two tags:

• 2024-09-22-test, against commit 4650a611850c03600e423d8385ab237308a8ff05
• 2024-09-22-test-2, against commit 6650b7ff386c9cb8a2e199ae1fd78571aa3ac336

The app is pinned to 2024-09-22-test, so SHOULD be using commit 4650.... However, it is not - see below;

Expected behavior

ArgoCD should use the commit that the tag is pinned to (4650...). However, it is using 6650... instead.

Screenshots

See git history below, with commits etc.

Version

v2.12.3+6b9cd82

Logs

Have enabled debug logs, but can't see anything of note.

My initial reaction is that this may be an issue to do #17566; somehow the tags above are being treated as semver, when they shouldn't be. This then leads to the tags being updated to later commits, even though we expect them to be fixed.
This would explain why ArgoCD uses the second tag, rather than HEAD.

Does that sound about right, or am I barking up the wrong tree?