fix: resource tracking normalization shuold drop empty labels #7909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7909 +/- ##
==========================================
- Coverage 41.47% 41.47% -0.01%
==========================================
Files 169 169
Lines 22328 22331 +3
==========================================
+ Hits 9260 9261 +1
- Misses 11744 11745 +1
- Partials 1324 1325 +1
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Dec 13, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Followup fix for #7899 . To avoid the reporting diff after switching to new tracking method the normalization process drops expected label from live resource. If it is last label the normalization should drop
labelfield altogether.