Skip to content

Conversation

pasha-codefresh
Copy link
Member

Typo in doc

Signed-off-by: pashavictorovich <pavel@codefresh.io>
This reverts commit d0e2135

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #7873 (41bf498) into master (0f2f9a9) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7873      +/-   ##
==========================================
+ Coverage   41.44%   41.48%   +0.03%     
==========================================
  Files         169      169              
  Lines       22239    22254      +15     
==========================================
+ Hits         9218     9232      +14     
  Misses      11703    11703              
- Partials     1318     1319       +1     
Impacted Files Coverage Δ
util/rbac/rbac.go 76.50% <0.00%> (-0.55%) ⬇️
controller/appcontroller.go 52.93% <0.00%> (-0.10%) ⬇️
server/application/application.go 32.77% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 55.19% <0.00%> (+0.20%) ⬆️
util/settings/settings.go 47.24% <0.00%> (+0.40%) ⬆️
util/notification/expression/strings/strings.go 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2f9a9...41bf498. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pasha-codefresh !

@jannfis jannfis merged commit 2087eaa into argoproj:master Dec 7, 2021
alexmt pushed a commit that referenced this pull request Dec 8, 2021
* move projects

Signed-off-by: pashavictorovich <pavel@codefresh.io>

* Revert "move projects"

This reverts commit d0e2135

Signed-off-by: pashavictorovich <pavel@codefresh.io>

* fix typo in resource tracking

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants