Skip to content

fix: css change for clear button in filters #7868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix: css change for clear button in filters #7868

merged 1 commit into from
Dec 6, 2021

Conversation

saumeya
Copy link
Contributor

@saumeya saumeya commented Dec 6, 2021 •
edited
Loading

Signed-off-by: saumeya saumeyakatyal@gmail.com

The current button has no spacing between the heading and looks like this -
clear-button-now
The PR implements the button towards the right
clear-button-changed

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@saumeya
fix: css change for clear button in filters
897037f 
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@saumeya saumeya requested review from alexmt and rbreeze December 6, 2021 13:30
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #7868 (897037f) into master (78e256e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7868   +/-   ##
=======================================
  Coverage   41.48%   41.48%           
=======================================
  Files         169      169           
  Lines       22254    22254           
=======================================
  Hits         9232     9232           
  Misses      11703    11703           
  Partials     1319     1319
Impacted Files Coverage Δ
util/settings/settings.go 47.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e256e...897037f. Read the comment docs.

rbreeze
rbreeze approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 7d59cbb into argoproj:master Dec 6, 2021
@saumeya saumeya deleted the filter-clear-button-position branch December 7, 2021 08:39
alexmt pushed a commit that referenced this pull request Dec 7, 2021
@saumeya @alexmt
fix: css change for clear button in filters (#7868)
48bdaba 
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

@alexmt alexmt Awaiting requested review from alexmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saumeya @rbreeze @alexmt