Skip to content

feat: allow hiding managed fields in resource manifest viewer #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2021
Merged

feat: allow hiding managed fields in resource manifest viewer #7855

merged 2 commits into from
Dec 3, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Dec 3, 2021

Closes #6089

PR improves the usability of resource manifest viewer. Following changes are implemented:

  • Added "Hide Managed Fields" checkbox. The button allows the user to hide metadata.managedFields field:
Screen.Recording.2021-12-03.at.1.00.15.PM.mov
  • Removes duplicate scroll within the editor. This makes it easier to navigate to the required part of a manifest and scroll no longer jump back and forth then manifest changes:
Screen.Recording.2021-12-03.at.1.06.08.PM.mov

alexmt added 2 commits December 3, 2021 10:08
@alexmt
fix: remove double scroll in editor
e485314 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt
feat: add Hide Managed Fields checkbox
f2d2df8 
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from rbreeze December 3, 2021 21:07
rbreeze
rbreeze approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #7855 (f2d2df8) into master (891d9b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7855   +/-   ##
=======================================
  Coverage   41.48%   41.48%           
=======================================
  Files         169      169           
  Lines       22256    22256           
=======================================
  Hits         9234     9234           
  Misses      11703    11703           
  Partials     1319     1319

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891d9b2...f2d2df8. Read the comment docs.

@alexmt alexmt merged commit ccd15d1 into argoproj:master Dec 3, 2021
alexmt pushed a commit that referenced this pull request Dec 3, 2021
@alexmt
feat: allow hiding managed fields in resource manifest viewer (#7855)
3f75a7f 
* fix: remove double scroll in editor

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

* feat: add Hide Managed Fields checkbox

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt deleted the editor-usability branch December 3, 2021 21:46
@chrisjohnson chrisjohnson mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: hide managed fields in the UI
2 participants
@alexmt @rbreeze