refactoring: upgrade casbin to latest stable version (v2.39.1) #7802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1171edf to
756d68e
Compare
pasha-codefresh
approved these changes
Nov 29, 2021
756d68e to
05192c6
Compare
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
05192c6 to
6de14e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #7802 +/- ##
=======================================
Coverage 41.44% 41.45%
=======================================
Files 169 169
Lines 22239 22243 +4
=======================================
+ Hits 9218 9220 +2
- Misses 11703 11704 +1
- Partials 1318 1319 +1
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Nov 30, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
The PR is an attempt to resolve #7801 . I've wasted a couple of days trying to find bug in Argo CD code but no luck. Another option is that cached enforce of casbin itself has a bug.
The PR upgrades casbin to most recent stable version which introduce 8 fixes for cached informer https://github.com/casbin/casbin/commits/master/enforcer_cached.go . I suggest merging this PR, test next release candidate another week and either close #7801 or rollback both casbin upgrade and caching changes.