docs: Remove misleading minus sign after version number #7559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7559 +/- ##
==========================================
- Coverage 41.40% 41.39% -0.02%
==========================================
Files 161 161
Lines 21622 21642 +20
==========================================
+ Hits 8952 8958 +6
- Misses 11408 11421 +13
- Partials 1262 1263 +1
Continue to review full report at Codecov.
|
alexmt
requested changes
Oct 28, 2021
| @@ -38,7 +38,7 @@ and might fail. To avoid failed syncs use `ARGOCD_GIT_ATTEMPTS_COUNT` environmen | |||
|
|
|||
| * `argocd_git_request_total` - Number of git requests. The metric provides two tags: `repo` - Git repo URL; `request_type` - `ls-remote` or `fetch`. | |||
|
|
|||
| * `ARGOCD_ENABLE_GRPC_TIME_HISTOGRAM` (v1.8+) - environment variable that enables collecting RPC performance metrics. Enable it if you need to troubleshoot performance issue. Note: metric is expensive to both query and store! | |||
There was a problem hiding this comment.
Thank you @terrytangyuan ! We've moved documentation to https://readthedocs.org/ and have documentation for multiple versions now. So we no longer need to specify version manually. Can you please remove (v1.8+) altogether?
There was a problem hiding this comment.
Good to know. Removed.
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
b68c26e to
b8cb5a5
Compare
alexmt
approved these changes
Oct 28, 2021
behoof4mind
pushed a commit
to iits-consulting/argo-cd
that referenced
this pull request
Oct 29, 2021
* docs: Remove unnecessary version numbers in high_availability.md Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Fix Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Denis Lavrushko <denis.lavrushko@iits-consulting.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
(v1.8+)-is a bit misleading since we meant to say v1.8 and above.Signed-off-by: Yuan Tang terrytangyuan@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: