Clarify key/cert encoding in docs for cluster credentials #7544 #7545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes argoproj#7544 Signed-off-by: Alex Stockinger <mail@alexstockinger.de>
jessesuen
reviewed
Oct 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #7545 +/- ##
=======================================
Coverage 41.38% 41.38%
=======================================
Files 161 161
Lines 21619 21619
=======================================
Hits 8948 8948
Misses 11408 11408
Partials 1263 1263
Continue to review full report at Codecov.
|
alexmt
approved these changes
Oct 28, 2021
behoof4mind
pushed a commit
to iits-consulting/argo-cd
that referenced
this pull request
Oct 29, 2021
Fixes argoproj#7544 Signed-off-by: Alex Stockinger <mail@alexstockinger.de> Signed-off-by: Denis Lavrushko <denis.lavrushko@iits-consulting.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just stumbled across a piece of documentation that IMO is slightly unclear. The comments for the key material in cluster credentials in the example don't state clearly that the PEM encoded keys/certs must additionally be base64 encoded - I consequently did it wrong the first time around.
I suggest adding some clarifying additional info in the example's comment.
Fixes #7544