Skip to content

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Oct 22, 2021

Closes: #7458 7458
TBD

  • 1. tests
  • 2. Documentation

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #7526 (dcaac1f) into master (b8510f3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7526      +/-   ##
==========================================
- Coverage   41.38%   41.36%   -0.03%     
==========================================
  Files         161      161              
  Lines       21618    21630      +12     
==========================================
  Hits         8947     8947              
- Misses      11408    11420      +12     
  Partials     1263     1263              
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 0.54% <0.00%> (-0.01%) ⬇️
util/settings/settings.go 46.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8510f3...dcaac1f. Read the comment docs.

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 7b0cf77 into argoproj:master Oct 28, 2021
behoof4mind pushed a commit to iits-consulting/argo-cd that referenced this pull request Oct 29, 2021
feat: Replace option in cli, sync command (argoproj#7526)

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: Denis Lavrushko <denis.lavrushko@iits-consulting.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: sync --replace
2 participants