Skip to content

feat: Show "Open application" link in Application details list view #7455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

feat: Show "Open application" link in Application details list view #7455

merged 1 commit into from
Oct 28, 2021

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Oct 15, 2021

Signed-off-by: Engin Diri engin.diri@mail.schwarz

Fixes: #7179

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@dirien dirien force-pushed the feat-application-link branch from 1badabf to cc49ea8 Compare October 15, 2021 17:11
feat: Show "Open application" link in Application details list view
8038a71 
Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@dirien dirien force-pushed the feat-application-link branch from cc49ea8 to 8038a71 Compare October 15, 2021 17:16
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #7455 (8038a71) into master (d7d8fe3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7455   +/-   ##
=======================================
  Coverage   41.32%   41.32%           
=======================================
  Files         161      161           
  Lines       21590    21590           
=======================================
  Hits         8921     8921           
  Misses      11408    11408           
  Partials     1261     1261
Impacted Files Coverage Δ
util/settings/settings.go 46.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d8fe3...8038a71. Read the comment docs.

@jannfis jannfis added the group:hacktoberfest-2023 Hacktoberfest 2023 label Oct 20, 2021
alexmt
alexmt approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@alexmt alexmt added the group:hacktoberfest-accepted Accepted Hacktoberfest contribution label Oct 28, 2021
@alexmt alexmt merged commit 4522a88 into argoproj:master Oct 28, 2021
@dirien dirien deleted the feat-application-link branch October 28, 2021 21:47
behoof4mind pushed a commit to iits-consulting/argo-cd that referenced this pull request Oct 29, 2021
feat: Show "Open application" link in Application details list view (a…
283cd8c 
…rgoproj#7455)

Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
Signed-off-by: Denis Lavrushko <denis.lavrushko@iits-consulting.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

@rbreeze rbreeze Awaiting requested review from rbreeze

@reginapizza reginapizza Awaiting requested review from reginapizza

Assignees
No one assigned
Labels
group:hacktoberfest-2023 Hacktoberfest 2023 group:hacktoberfest-accepted Accepted Hacktoberfest contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show "Open application" link in Application details list view
3 participants
@dirien @alexmt @jannfis