Skip to content

Conversation

pasha-codefresh
Copy link
Member

Continuation for #7251

During migration we should normalize annotation with specific key as label for prevent our of sync status inside existing resources

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh changed the title feat: Resource id nml feat: resource id normalization Oct 7, 2021
@pasha-codefresh pasha-codefresh changed the title feat: resource id normalization feat: Resources should be normalized in order to prevent our of sync during migration Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #7388 (2281d2a) into master (df5cce8) will increase coverage by 0.06%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7388      +/-   ##
==========================================
+ Coverage   41.17%   41.24%   +0.06%     
==========================================
  Files         161      161              
  Lines       21638    21525     -113     
==========================================
- Hits         8910     8878      -32     
+ Misses      11457    11384      -73     
+ Partials     1271     1263       -8     
Impacted Files Coverage Δ
util/argo/resource_tracking.go 69.62% <37.50%> (-8.16%) ⬇️
controller/state.go 68.02% <100.00%> (+0.08%) ⬆️
server/application/application.go 32.32% <0.00%> (-0.48%) ⬇️
server/application/logs.go 85.71% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5cce8...2281d2a. Read the comment docs.

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit b073621 into argoproj:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants