Skip to content

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Oct 1, 2021

Continuation for #7251

Implementation of annotation+label trackingMethod

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh requested a review from alexmt October 1, 2021 15:54
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #7342 (db6a2ac) into master (ebd87b7) will increase coverage by 0.02%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7342      +/-   ##
==========================================
+ Coverage   41.17%   41.19%   +0.02%     
==========================================
  Files         161      161              
  Lines       21612    21627      +15     
==========================================
+ Hits         8899     8910      +11     
- Misses      11446    11448       +2     
- Partials     1267     1269       +2     
Impacted Files Coverage Δ
util/argo/resource_tracking.go 83.33% <77.27%> (-3.91%) ⬇️
controller/cache/cache.go 10.50% <0.00%> (ø)
util/settings/settings.go 46.70% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.51% <0.00%> (ø)
controller/state.go 67.93% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd87b7...db6a2ac. Read the comment docs.

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit df7e5ff into argoproj:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants