Skip to content

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Oct 1, 2021

Continuation for #7251

Shared resource identified incorrectly if non label tracking method is defined

Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh requested a review from alexmt October 1, 2021 15:04
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #7341 (359f2f0) into master (ebd87b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7341   +/-   ##
=======================================
  Coverage   41.17%   41.18%           
=======================================
  Files         161      161           
  Lines       21612    21614    +2     
=======================================
+ Hits         8899     8901    +2     
  Misses      11446    11446           
  Partials     1267     1267           
Impacted Files Coverage Δ
controller/cache/cache.go 10.50% <ø> (ø)
cmd/argocd/commands/admin/app.go 30.90% <100.00%> (ø)
controller/appcontroller.go 53.30% <100.00%> (ø)
controller/state.go 67.93% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd87b7...359f2f0. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch!

@alexmt alexmt merged commit 3d4deeb into argoproj:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants