Skip to content

feat: add test to redis_hook.go #7233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2021
Merged

feat: add test to redis_hook.go #7233

merged 2 commits into from
Sep 16, 2021

Conversation

pasha-codefresh
Copy link
Member

Signed-off-by: pashavictorovich pavel@codefresh.io

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@pasha-codefresh
add test to redis_hook.go
8d6b521 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh added the component:test Test requests (e2e or unit) label Sep 16, 2021
@pasha-codefresh pasha-codefresh changed the title add test to redis_hook.go feat: add test to redis_hook.go Sep 16, 2021
@pasha-codefresh
restart action
f2f5c9b 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #7233 (f2f5c9b) into master (6f794d0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7233      +/-   ##
==========================================
+ Coverage   41.10%   41.12%   +0.01%     
==========================================
  Files         160      160              
  Lines       21337    21337              
==========================================
+ Hits         8770     8774       +4     
+ Misses      11317    11313       -4     
  Partials     1250     1250
Impacted Files Coverage Δ
util/cache/redis_hook.go 62.50% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f794d0...f2f5c9b. Read the comment docs.

alexmt
alexmt approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexmt alexmt merged commit 91fea14 into argoproj:master Sep 16, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 21, 2021
@pasha-codefresh @plakyda1
feat: add test to redis_hook.go (argoproj#7233)
9edf396 
* add test to redis_hook.go

Signed-off-by: pashavictorovich <pavel@codefresh.io>

* restart action

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@pasha-codefresh @plakyda1
feat: add test to redis_hook.go (argoproj#7233)
4963aa7 
* add test to redis_hook.go

Signed-off-by: pashavictorovich <pavel@codefresh.io>

* restart action

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
component:test Test requests (e2e or unit)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pasha-codefresh @alexmt