Skip to content

fix(ui): More tab was displayed for resources that did not have extension installed #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix(ui): More tab was displayed for resources that did not have extension installed #7209

merged 1 commit into from
Sep 14, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Sep 13, 2021

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@rbreeze
fix(ui): More tab was displayed for resources that did not have exten…
970d231 
…sions installed

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt September 13, 2021 23:38
alexmt
alexmt approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it!

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #7209 (970d231) into master (a9f009c) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7209      +/-   ##
==========================================
- Coverage   41.12%   41.03%   -0.09%     
==========================================
  Files         158      158              
  Lines       21366    21299      -67     
==========================================
- Hits         8787     8741      -46     
+ Misses      11313    11305       -8     
+ Partials     1266     1253      -13
Impacted Files Coverage Δ
server/application/application.go 32.11% <0.00%> (-0.66%) ⬇️
pkg/apis/application/v1alpha1/types.go 57.51% <0.00%> (-0.36%) ⬇️
server/repository/repository.go 35.65% <0.00%> (-0.24%) ⬇️
cmd/argocd/commands/cluster.go 5.68% <0.00%> (-0.23%) ⬇️
server/server.go 54.65% <0.00%> (-0.20%) ⬇️
reposerver/repository/repository.go 60.84% <0.00%> (-0.16%) ⬇️
cmd/argocd/commands/app.go 0.54% <0.00%> (-0.02%) ⬇️
cmd/argocd/commands/repo.go 0.00% <0.00%> (ø)
cmd/argocd/commands/admin/cluster.go 0.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/hack.go 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f009c...970d231. Read the comment docs.

@alexmt alexmt merged commit 3df6be7 into argoproj:master Sep 14, 2021
alexmt pushed a commit that referenced this pull request Sep 14, 2021
@rbreeze @alexmt
fix(ui): More tab was displayed for resources that did not have exten…
6e9b18e 
…sions installed (#7209)

Signed-off-by: Remington Breeze <remington@breeze.software>
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@rbreeze @plakyda1
fix(ui): More tab was displayed for resources that did not have exten…
77017ef 
…sions installed (argoproj#7209)

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbreeze @alexmt