Skip to content

fix: fixed small typos in github credentials types #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2021
Merged

fix: fixed small typos in github credentials types #7161

merged 1 commit into from
Sep 9, 2021

Conversation

suraj-zemoso
Copy link
Contributor

@suraj-zemoso suraj-zemoso commented Sep 4, 2021 •
edited
Loading

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@suraj-zemoso
fixed small typos in github credentials types
5c9c876 
Signed-off-by: suraj-zemoso <suraj.bodade@zemosolabs.com>
@suraj-zemoso suraj-zemoso changed the title fixed small typos in github credentials types fix: fixed small typos in github credentials types Sep 4, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #7161 (5c9c876) into master (9559613) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7161   +/-   ##
=======================================
  Coverage   41.14%   41.14%           
=======================================
  Files         158      158           
  Lines       21230    21230           
=======================================
  Hits         8736     8736           
  Misses      11241    11241           
  Partials     1253     1253

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9559613...5c9c876. Read the comment docs.

@rbreeze rbreeze merged commit fc49eb2 into argoproj:master Sep 9, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@suraj-zemoso @plakyda1
fixed small typos in github credentials types (argoproj#7161)
0418a1c 
Signed-off-by: suraj-zemoso <suraj.bodade@zemosolabs.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suraj-zemoso @rbreeze