fix: use selected helm-values #7099 #7166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Münzl <thomasmuenzl@icloud.com>
Codecov Report
@@ Coverage Diff @@
## master #7166 +/- ##
==========================================
- Coverage 41.14% 41.14% -0.01%
==========================================
Files 158 158
Lines 21230 21232 +2
==========================================
Hits 8736 8736
- Misses 11241 11242 +1
- Partials 1253 1254 +1
Continue to review full report at Codecov.
|
alexmt
pushed a commit
that referenced
this pull request
Sep 10, 2021
Signed-off-by: Thomas Münzl <thomasmuenzl@icloud.com>
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Thomas Münzl <thomasmuenzl@icloud.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
with v2.1 the selected value-files with helm-charts are not used correctly.
Problem evolved from this PR https://github.com/argoproj/argo-cd/pull/5634/files#diff-66db997cf6001ce63d5c5803380962f4b474aae67abacc9e86192673080d2c59R1239
valueFilescontains all available value-files in the chosen directory, but those are used afterwards to retrieve all Parameters.It should be done as it was implemented before: https://github.com/argoproj/argo-cd/pull/5634/files#diff-66db997cf6001ce63d5c5803380962f4b474aae67abacc9e86192673080d2c59L1220
q.Source.Helm.ValueFilescontains the value-files the user selected in the UI, whileres.Helm.ValueFilesshould contain all available value-files to be displayed as auto-complete in the UI.It seems that currently all value-files in the app-directory are used to generate the parameters.
This should solve issue #7099.
Fixes #7099
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: