Skip to content

feat: ability to switch user during test execution #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2021
Merged

feat: ability to switch user during test execution #7164

merged 7 commits into from
Sep 9, 2021

Conversation

pasha-codefresh
Copy link
Member

Signed-off-by: pashavictorovich pavel@codefresh.io

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@pasha-codefresh
account tests
a92100e 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Sep 5, 2021 •
edited
Loading

Codecov Report

Merging #7164 (8ad8a8f) into master (2405482) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7164      +/-   ##
==========================================
- Coverage   41.14%   41.06%   -0.09%     
==========================================
  Files         158      158              
  Lines       21230    21274      +44     
==========================================
  Hits         8736     8736              
- Misses      11241    11285      +44     
  Partials     1253     1253
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 0.54% <0.00%> (-0.02%) ⬇️
util/settings/settings.go 47.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2405482...8ad8a8f. Read the comment docs.

@pasha-codefresh
fix linter
5feaba1 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
Fix how we reset state in case with switch user
7593c91 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
restart tests
e78ee21 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
Fix how we reset state in case with switch user
141f017 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh added component:test Test requests (e2e or unit) enhancement New feature or request labels Sep 7, 2021
alexmt
alexmt requested changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement. Thank you! Added comment regarding generating a token for non-admins users. All other changes look good.

@pasha-codefresh
change a way how to generate session service
14607ac 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
fix linter
8ad8a8f 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
alexmt
alexmt approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit c64e8df into argoproj:master Sep 9, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@pasha-codefresh @plakyda1
feat: ability to switch user during test execution (argoproj#7164)
9c1219b 
feat: ability to switch user during test execution (argoproj#7164)

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
component:test Test requests (e2e or unit) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pasha-codefresh @alexmt