Skip to content

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Sep 1, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Fixes #7046

image

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from rbreeze September 1, 2021 21:55
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #7135 (70e5c63) into master (dd26a48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7135   +/-   ##
=======================================
  Coverage   41.12%   41.12%           
=======================================
  Files         158      158           
  Lines       21366    21366           
=======================================
  Hits         8787     8787           
  Misses      11313    11313           
  Partials     1266     1266           
Impacted Files Coverage Δ
util/settings/settings.go 47.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd26a48...70e5c63. Read the comment docs.

@alexmt alexmt merged commit 8fbcc1c into argoproj:master Sep 1, 2021
@alexmt alexmt deleted the 7046-filter-issue branch September 1, 2021 22:33
alexmt pushed a commit that referenced this pull request Sep 2, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster filter popping out of box
2 participants