Skip to content

feat: scoped repo e2e tests #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2021
Merged

feat: scoped repo e2e tests #7110

merged 3 commits into from
Aug 30, 2021

Conversation

pasha-codefresh
Copy link
Member

Signed-off-by: pashavictorovich pavel@codefresh.io

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@pasha-codefresh
scoped repo e2e tests
24c3274 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh
remove redundant changes
e175ca3 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Aug 30, 2021 •
edited
Loading

Codecov Report

Merging #7110 (63e6ef2) into master (4290304) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7110   +/-   ##
=======================================
  Coverage   41.12%   41.12%           
=======================================
  Files         158      158           
  Lines       21365    21365           
=======================================
  Hits         8786     8786           
  Misses      11313    11313           
  Partials     1266     1266
Impacted Files Coverage Δ
util/settings/settings.go 47.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4290304...63e6ef2. Read the comment docs.

@pasha-codefresh
restart ci
63e6ef2 
Signed-off-by: pashavictorovich <pavel@codefresh.io>
alexmt
alexmt approved these changes Aug 30, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit dd2900e into argoproj:master Aug 30, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@pasha-codefresh @plakyda1
feat: scoped repo e2e tests (argoproj#7110)
38071e5 
feat: scoped repo e2e tests (argoproj#7110)

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pasha-codefresh @alexmt