Skip to content

chore: Upgrade dex server image to 2.30.0 #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2021
Merged

chore: Upgrade dex server image to 2.30.0 #7102

merged 2 commits into from
Sep 3, 2021

Conversation

pdrastil
Copy link
Member

@pdrastil pdrastil commented Aug 27, 2021 •
edited
Loading

This PR relates to #7089

  • Upgrade to latest dex server that supports K8s CRD storage

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Aug 27, 2021 •
edited
Loading

Codecov Report

Merging #7102 (75df040) into master (a940cb5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7102   +/-   ##
=======================================
  Coverage   41.12%   41.12%           
=======================================
  Files         158      158           
  Lines       21363    21365    +2     
=======================================
+ Hits         8785     8786    +1     
- Misses      11312    11313    +1     
  Partials     1266     1266
Impacted Files Coverage Δ
server/repository/repository.go 35.62% <0.00%> (-0.15%) ⬇️
server/logout/logout.go 77.77% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a940cb5...75df040. Read the comment docs.

@pdrastil pdrastil mentioned this pull request Aug 27, 2021
Merged
5 tasks
@pdrastil
chore: Upgrade dex server to 2.30.0
bd21a8c 
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
@pdrastil pdrastil marked this pull request as draft August 28, 2021 14:00
@pdrastil
Copy link
Member Author

When testing modifications for dex to support HA I've found that liveness / readiness probes might prevent startup of dex server container when argocd-dex utility executessettings.IsDexConfigured() and dex serve is not executed. I will remove the probes for now because this needs more work on the utility side.

@pdrastil
Revert dex server probes
75df040 
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
@pdrastil pdrastil marked this pull request as ready for review August 28, 2021 14:41
jannfis
jannfis approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @pdrastil !

@jannfis jannfis merged commit d9e8a0f into argoproj:master Sep 3, 2021
@pdrastil pdrastil deleted the upgrade-dex branch September 4, 2021 10:53
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@pdrastil @plakyda1
chore: Upgrade dex server image to 2.30.0 (argoproj#7102)
115d16f 
* chore: Upgrade dex server to 2.30.0

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* Revert dex server probes

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdrastil @jannfis