fix: use basehref as cookie-path #7105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Münzl <thomasmuenzl@icloud.com>
Codecov Report
@@ Coverage Diff @@
## master #7105 +/- ##
==========================================
+ Coverage 41.08% 41.12% +0.03%
==========================================
Files 158 158
Lines 21349 21364 +15
==========================================
+ Hits 8772 8785 +13
- Misses 11311 11313 +2
Partials 1266 1266
Continue to review full report at Codecov.
|
jannfis
approved these changes
Sep 3, 2021
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Thomas Münzl <thomasmuenzl@icloud.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #7092 with non-oidc logins, the configured
--rootpathvalue is used as Cookie-Path which stores the current token.When invalidating the token after logout, the cookie-path from
--basehrefis used, which is part of the bugfix in #7092.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: