Codecov Report

Merging #7042 (b4702a1) into master (b271d6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7042   +/-   ##
=======================================
  Coverage   41.12%   41.12%           
=======================================
  Files         158      158           
  Lines       21364    21364           
=======================================
  Hits         8785     8785           
  Misses      11313    11313           
  Partials     1266     1266           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b271d6a...b4702a1. Read the comment docs.

@rbreeze Good catch! I searched with "Suspended" in code and thought I covered everywhere but missed this one. I will make a PR against argo-ui repo to add this new suspended color.

I looked into the application-table component code, and I see we are applying both health status color and comparison status color for the left border color. In the style sheet it's missing style definition of applications-list__entry--health-Suspended {}, so the health status color is not applied. As you mentioned, the health status color is preferred to be used for the left border color, can I safely remove the applications-list__entry--comparison-${app.status.sync.status} class name? So that only health status color will matter for the left border.

Code reference:

• argo-cd/ui/src/app/applications/components/applications-list/applications-table.tsx

  Line 42 in d12eafa

  applications-list__entry applications-list__entry--comparison-${app.status.sync.status}

• argo-cd/ui/src/app/applications/components/applications-list/applications-tiles.tsx

  Line 108 in d12eafa

  className={`argo-table-list__row applications-list__entry applications-list__entry--comparison-${

can I safely remove the applications-list__entry--comparison-${app.status.sync.status} class name?

Yeah, this should be okay.

I will make a PR against argo-ui repo to add this new suspended color.

I think this should be merged into argo-ui before this PR is merged, so that we can bump the argo-ui commit SHA in this PR.

Just merged argoproj/argo-ui#135. You can bump the argo-ui commit SHA using yarn add git+https://github.com/argoproj/argo-ui.git

@rbreeze Thanks for the confirmation. I see Alex has merged my argo-ui PR for this PR. I'm going to update this PR soon.

yarn add git+https://github.com/argoproj/argo-ui.git

Thanks for merging my PR and thanks for the tips. Making a push soon.

It looks like you have a reference to $argo-suspended-color leftover:

ERROR in ./src/app/applications/components/applications-list/applications-list.scss (./node_modules/raw-loader!./node_modules/sass-loader/lib/loader.js!./src/app/applications/components/applications-list/applications-list.scss)
159
Module build failed (from ./node_modules/sass-loader/lib/loader.js):
160

161
            border-left-color: $argo-suspended-color;
162
                              ^
163
      Undefined variable: "$argo-suspended-color".
164
      in /home/runner/work/argo-cd/argo-cd/ui/src/app/applications/components/applications-list/applications-list.scss (line 45, column 32)

$argo-suspended-color is the one I added in argo-ui repo. It's showing in my local 'node_modules/argo-ui/src/styles/config' and tested that app runs on my local with no errors regarding this variable. I included yarn.lock which has the argo-ui update in this PR as well. Is there anything wrong with my process that makes it not picking up my argo-ui node_module update?

@ciiay I forgot to clarify. The yarn add git+https://github.com/argoproj/argo-ui.git should be executed in ui directory. I think you run it in repo root directory.

Please don't forgot to added yarn.lock - it was created by yarn add command.

@alexmt Thanks for the information. It looks like this directory information is missing from this page. https://argoproj.github.io/argo-cd/developer-guide/dependencies/#argo-ui-components . How could I or anyone update this documentation?

How could I or anyone update this documentation?

You can make changes in https://github.com/argoproj/argo-cd/blob/master/docs/developer-guide/dependencies.md#argo-ui-components