Skip to content

fix(ui): calculate service info correctly for networking.k8s.io/v1 ingress #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2021
Merged

fix(ui): calculate service info correctly for networking.k8s.io/v1 ingress #6923

merged 2 commits into from
Aug 26, 2021

Conversation

backjo
Copy link
Contributor

@backjo backjo commented Aug 6, 2021 •
edited
Loading

Closes #5839

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #6923 (fe79673) into master (819225c) will decrease coverage by 0.01%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6923      +/-   ##
==========================================
- Coverage   41.13%   41.12%   -0.02%     
==========================================
  Files         157      158       +1     
  Lines       20993    21363     +370     
==========================================
+ Hits         8636     8785     +149     
- Misses      11129    11312     +183     
- Partials     1228     1266      +38
Impacted Files Coverage Δ
controller/cache/info.go 65.33% <96.29%> (+1.82%) ⬆️
server/account/account.go 65.89% <0.00%> (-3.28%) ⬇️
server/project/project.go 52.69% <0.00%> (-2.78%) ⬇️
util/argo/argo.go 62.75% <0.00%> (-2.14%) ⬇️
util/tls/tls.go 77.99% <0.00%> (-1.44%) ⬇️
util/settings/settings.go 47.15% <0.00%> (-0.62%) ⬇️
cmd/util/cluster.go 39.39% <0.00%> (-0.61%) ⬇️
util/db/cluster.go 59.06% <0.00%> (-0.46%) ⬇️
cmd/util/repo.go 0.00% <0.00%> (ø)
controller/metrics/clustercollector.go 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819225c...fe79673. Read the comment docs.

alexmt
alexmt previously requested changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @backjo ! Changes look good. Can you please resolve linter error (resort imports) and revert change not related to the PR?

@backjo backjo force-pushed the support-ingress-v1 branch from c692c3d to e9919a4 Compare August 14, 2021 04:35
@backjo
fix(ui): calculate service info correctly for networking.k8s.io/v1 in…
59f789a 
…gress

Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo backjo force-pushed the support-ingress-v1 branch from e9919a4 to 59f789a Compare August 14, 2021 04:40
@backjo
Copy link
Contributor Author

backjo commented Aug 14, 2021

@alexmt should be good to go.

@backjo backjo requested a review from alexmt August 15, 2021 20:09
@backjo
Copy link
Contributor Author

backjo commented Aug 25, 2021

Anything else needed here? @alexmt @jessesuen

jessesuen
jessesuen approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. One small nit

@backjo
Address review comments
fe79673 
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo
Copy link
Contributor Author

backjo commented Aug 26, 2021

Thx @jessesuen - updated to reflect your comment.

@jessesuen jessesuen dismissed alexmt’s stale review August 26, 2021 21:46

feedback addressed

@jessesuen jessesuen merged commit a940cb5 into argoproj:master Aug 26, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@backjo @plakyda1
fix(ui): calculate service info correctly for networking.k8s.io/v1 in…
5e840f1 
…gress (argoproj#6923)

Signed-off-by: Jonah Back <jonah@jonahback.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

@alexmt alexmt Awaiting requested review from alexmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network view does not map Ingress with networking.k8s.io/v1 apiVersion to targeted services.
3 participants
@backjo @alexmt @jessesuen