Skip to content

docs: add configuration guide for using Google Load Balancers with GKE #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2021
Merged

docs: add configuration guide for using Google Load Balancers with GKE #6747

merged 2 commits into from
Aug 30, 2021

Conversation

alvarogonzalez-packlink
Copy link
Contributor

Signed-off-by: alvarogonzalez-packlink alvarogonzalez@packlink.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

This is my first PR, let me know if you see something funny or unfitting to your documentation style.

@alvarogonzalez-packlink
docs: add configuration guide for using Google Load Balancers with GKE
a134d20 
Signed-off-by: alvarogonzalez-packlink <alvarogonzalez@packlink.com>
jannfis
jannfis reviewed Aug 16, 2021
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our docs, @alvarogonzalez-packlink ! I can't validate the documentation because I don't have a GKE test bed, but it looks plausible to me.

I have only two minor comments, please see below. They are not a must to address, but I think it would help with keeping docs consistent.

@alvarogonzalez-packlink
docs: fix format on notes and warnings
99e2f16 
Signed-off-by: alvarogonzalez-packlink <alvarogonzalez@packlink.com>
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #6747 (99e2f16) into master (30d2ba1) will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6747      +/-   ##
==========================================
- Coverage   41.30%   40.68%   -0.62%     
==========================================
  Files         156      158       +2     
  Lines       20702    21291     +589     
==========================================
+ Hits         8550     8663     +113     
- Misses      10944    11398     +454     
- Partials     1208     1230      +22
Impacted Files Coverage Δ
util/cache/cache.go 56.96% <0.00%> (-13.26%) ⬇️
server/project/project.go 52.89% <0.00%> (-2.57%) ⬇️
util/jwt/jwt.go 60.00% <0.00%> (-1.91%) ⬇️
util/tls/tls.go 77.99% <0.00%> (-1.44%) ⬇️
controller/cache/info.go 63.50% <0.00%> (-1.38%) ⬇️
server/server.go 53.61% <0.00%> (-1.34%) ⬇️
util/db/cluster.go 59.52% <0.00%> (-0.48%) ⬇️
controller/appcontroller.go 52.95% <0.00%> (-0.42%) ⬇️
util/helm/cmd.go 29.87% <0.00%> (-0.37%) ⬇️
server/cluster/cluster.go 17.54% <0.00%> (-0.32%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d2ba1...99e2f16. Read the comment docs.

jannfis
jannfis approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jannfis jannfis merged commit 6897aa4 into argoproj:master Aug 30, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
@alvarogonzalez-packlink @plakyda1
docs: add configuration guide for using Google Load Balancers with GKE (
2054518 
argoproj#6747)

* docs: add configuration guide for using Google Load Balancers with GKE

Signed-off-by: alvarogonzalez-packlink <alvarogonzalez@packlink.com>

* docs: fix format on notes and warnings

Signed-off-by: alvarogonzalez-packlink <alvarogonzalez@packlink.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarogonzalez-packlink @jannfis