Skip to content

feat(ui): User defined information banner #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 2, 2021
Merged

feat(ui): User defined information banner #5299

merged 11 commits into from
Feb 2, 2021
+305 −70

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jan 22, 2021 •
edited
Loading

Screen Shot 2021-01-22 at 11 14 32 AM

Note: text-decoration: underline is present only if a user configured a URL in argocd-cm.yaml. This is because the default link color is too light to be visible with the banner background, and it should be apparent that it's clickable.

Builds upon #4626

Fix #4230

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@rbreeze rbreeze requested a review from alexmt January 22, 2021 19:16
@rbreeze
Lint
287d75a 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
Lint
789dd54 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze mentioned this pull request Jan 26, 2021
Closed
7 tasks
@rbreeze rbreeze added this to the v1.9 milestone Jan 27, 2021
alexmt
alexmt requested changes Feb 1, 2021
View reviewed changes
@rbreeze
Address review comments
4d4d6a3 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt February 2, 2021 18:03
alexmt
alexmt requested changes Feb 2, 2021
View reviewed changes
@rbreeze
Add noopener noreferrer to banner link
939d30b 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt February 2, 2021 20:01
alexmt
alexmt approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome!

@rbreeze rbreeze merged commit d6d534a into argoproj:master Feb 2, 2021
@rbreeze rbreeze deleted the ui-banner branch February 2, 2021 20:24
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@rbreeze @gaganhegde @Shubhama19
feat(ui): User defined information banner (argoproj#5299)
4a5057f 
Signed-off-by: Remington Breeze <remington@breeze.software>
Co-authored-by: gaganeggday <gh1268@rit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

UI banner mechanism to announce messages
3 participants
@rbreeze @alexmt @gaganhegde