Constraint docker-swarm #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function get control changed, so tests need to be changed accordingly
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 51.51% 44.44% -7.08%
==========================================
Files 3 4 +1
Lines 132 153 +21
==========================================
Hits 68 68
- Misses 56 76 +20
- Partials 8 9 +1
Continue to review full report at Codecov.
|
|
Does this need a new release of bench-common? |
|
Yes we need to cut a new release for bench-common and then it should work just fine |
use Bench-common version 0.4.3
update to bench-common 0.4.3
Fix typo - missing } and handling error from function GetSubstitutionMap
lizrice
approved these changes
Sep 2, 2020
Co-authored-by: Liz Rice <liz@lizrice.com>
Co-authored-by: Liz Rice <liz@lizrice.com>
Co-authored-by: Liz Rice <liz@lizrice.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docker-swarm as a constraint and auto-detect if swarm is active.
Fix #61
But need to wait for #79 and aquasecurity/bench-common#102 to be merged.
Until then leaving it as a draft