feat: support cosign veryf-blob's --bundle option #3711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hmm. It doesn't work. packages:
- type: github_release
repo_owner: cert-manager
repo_name: cmctl
description: the command line utility that makes cert-manager'ing easier
version_constraint: "false"
version_overrides:
- version_constraint: "true"
asset: cmctl_{{.OS}}_{{.Arch}}
format: raw
checksum:
type: github_release
asset: checksums.txt
algorithm: sha256
cosign:
bundle:
type: github_release
asset: checksums.txt.cosign.bundle$ ~/go/bin/aqua exec -- cmctl -v
INFO[0000] download and unarchive the package aqua_version= env=darwin/arm64 exe_name=cmctl package_name=cert-manager/cmctl package_version=v2.1.1 program=aqua registry=standard
Downloading cert-manager/cmctl v2.1.1 100% |█████████████████████████████████████████████████████████████████| (60/60 MB, 34 MB/s)
INFO[0003] downloading a checksum file aqua_version= env=darwin/arm64 exe_name=cmctl package_name=cert-manager/cmctl package_version=v2.1.1 program=aqua registry=standard
error: flag needs an argument: 'v' in -v |
|
|
Okay. It worked. $ ~/go/bin/aqua exec -- cmctl -V
INFO[0000] download and unarchive the package aqua_version= env=darwin/arm64 exe_name=cmctl package_name=cert-manager/cmctl package_version=v2.1.1 program=aqua registry=standard
Downloading cert-manager/cmctl v2.1.1 100% |█████████████████████████████████████████████████████████████████| (60/60 MB, 37 MB/s)
INFO[0002] downloading a checksum file aqua_version= env=darwin/arm64 exe_name=cmctl package_name=cert-manager/cmctl package_version=v2.1.1 program=aqua registry=standard
INFO[0003] verifying a file with Cosign aqua_version= env=darwin/arm64 exe_name=cmctl package_name=cert-manager/cmctl package_version=v2.1.1 program=aqua registry=standard
Verified OK
error: unknown shorthand flag: 'V' in -Vpackages:
- type: github_release
repo_owner: cert-manager
repo_name: cmctl
description: the command line utility that makes cert-manager'ing easier
version_constraint: "false"
version_overrides:
- version_constraint: "true"
asset: cmctl_{{.OS}}_{{.Arch}}
format: raw
checksum:
type: github_release
asset: checksums.txt
algorithm: sha256
cosign:
bundle:
type: github_release
asset: checksums.txt.cosign.bundle
opts:
- --certificate-oidc-issuer
- "https://token.actions.githubusercontent.com"
- --certificate-identity
- https://github.com/cert-manager/cmctl/.github/workflows/release.yaml@refs/tags/{{.Version}} |
6 tasks
jdx
pushed a commit
to jdx/mise
that referenced
this pull request
Jun 9, 2025
Fixes #5287. Basically re-implements aquaproj/aqua#3711. Since `bundle` option doesn't allow URL as an arg, it downloads the file and verifies using the file. ref: sigstore/cosign#4119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3682
https://aquaproj.github.io/docs/reference/registry-config/cosign/
This pull request adds a field
.cosign.bundleto supportcosign verify-blob's--bundleoption.This is same with cosign's other settings such as
key,certificate, andsignature.e.g. https://github.com/cert-manager/cmctl/releases/tag/v2.1.1