Skip to content

feat: Return full node dicts #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 23, 2025
Merged

feat: Return full node dicts #73

merged 11 commits into from
May 23, 2025

Conversation

j6k4m8
Copy link
Member

@j6k4m8 j6k4m8 commented Apr 15, 2025

fixes #57

@j6k4m8 j6k4m8 changed the title feat: Return full node dicts [wip] feat: Return full node dicts Apr 15, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #73 will degrade performances by 12.36%

Comparing full-node-returns (c3e6490) with master (3200fb0)

Summary

❌ 8 regressions
✅ 73 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_alias_with_single_variable_length_relationship[DiGraph] 33.3 ms 37.7 ms -11.53%
❌ test_alias_with_single_variable_length_relationship[MultiDiGraph] 33.4 ms 37.7 ms -11.48%
❌ test_node_type_edge_hop[DiGraph] 52.6 ms 59 ms -10.94%
❌ test_node_type_edge_hop[MultiDiGraph] 52.8 ms 59.2 ms -10.83%
❌ test_complex_variable_length_relationship[DiGraph] 17.7 ms 19.8 ms -10.89%
❌ test_complex_variable_length_relationship[MultiDiGraph] 17.7 ms 19.8 ms -10.79%
❌ test_single_variable_length_relationship[DiGraph] 46 ms 52.5 ms -12.36%
❌ test_single_variable_length_relationship[MultiDiGraph] 46.1 ms 52.6 ms -12.35%

@j6k4m8
Copy link
Member Author

j6k4m8 commented Apr 16, 2025

@AdrianVollmer @ntjess — pushing so you can follow along. Unfortunately, a bit more involved than I was hoping; currently detangling the ID(•) function...

@j6k4m8 j6k4m8 mentioned this pull request Apr 27, 2025
Closed
@j6k4m8 j6k4m8 marked this pull request as ready for review May 22, 2025 21:58
@j6k4m8 j6k4m8 changed the title [wip] feat: Return full node dicts feat: Return full node dicts May 22, 2025
@j6k4m8
Copy link
Member Author

j6k4m8 commented May 22, 2025

This is a pretty sizeable API change, will definitely be a breaking change. Looking at how best to accommodate; I think this will need to be a major version bump.

@j6k4m8 j6k4m8 mentioned this pull request May 23, 2025
Closed
@j6k4m8 j6k4m8 merged commit e95d53c into master May 23, 2025
7 checks passed
@j6k4m8 j6k4m8 deleted the full-node-returns branch May 23, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: parity between RETURN <node> and RETURN <relationship>
1 participant
@j6k4m8