Skip to content

fix: handle null subgraph schema check results #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix: handle null subgraph schema check results #2639

merged 1 commit into from
Jun 23, 2025

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Jun 23, 2025

Some customers reported that they get the E005 error when running rover subgraph check, even though the schema check passes on Studio. I managed to reproduce it and realized that this error can happen if the operations check task takes too long. So, when Rover tries to fetch the results for the workflow, the operations check hasn’t finished yet. This behavior is also clearly documented in the Platform API schema.

Shot 2025-06-23 at 08 54 39

To resolve this timing issue, we've modified the code so it doesn't throw MalformedResponse. This change also aligns with how rover graph check handles null schema check results:

rover/crates/rover-client/src/operations/graph/check_workflow/runner.rs

Lines 108 to 123 in fe86b2c

OperationsCheckTask(typed_task) => {
operations_status = Some(task.status);
operations_target_url = task.target_url;
if let Some(result) = typed_task.result {
number_of_checked_operations =
result.number_of_checked_operations.try_into().unwrap();
operations_result = Some(result);
}
}
LintCheckTask(typed_task) => {
lint_status = Some(task.status);
lint_target_url = task.target_url;
if let Some(result) = typed_task.result {
lint_result = Some(result)
}
}

@DaleSeo DaleSeo self-assigned this Jun 23, 2025
@DaleSeo DaleSeo requested review from a team as code owners June 23, 2025 13:08
@DaleSeo DaleSeo requested a review from swcollard June 23, 2025 13:38
swcollard
swcollard approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@swcollard swcollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the tests with the varying response shapes

@DaleSeo DaleSeo added the fix 🩹 fixes a bug label Jun 23, 2025
@DaleSeo DaleSeo merged commit 17de128 into main Jun 23, 2025
30 checks passed
@DaleSeo DaleSeo deleted the GT-213 branch June 23, 2025 19:44
@DaleSeo DaleSeo added this to the v0.34.1 milestone Jun 23, 2025
@DaleSeo DaleSeo mentioned this pull request Jun 23, 2025
Merged
DaleSeo added a commit that referenced this pull request Jun 24, 2025
@DaleSeo
release: v0.34.1 (#2640)
6c26509 
# [0.34.1] - 2025-06-23
## 🐛 Fixes
- **Handle null subgraph schema check results - @DaleSeo PR #2639**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcollard swcollard swcollard approved these changes

Assignees

@DaleSeo DaleSeo

Labels
fix 🩹 fixes a bug
Projects
None yet
Milestone
v0.34.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DaleSeo @swcollard