Skip to content

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix the issue that the length of private namespaces are mis-calculated

Which issue(s) this PR fixes:

Fixes #5073

Brief changelog

  • Fix the logic of shouldAppendNamespacePrefix

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c21659) 49.60% compared to head (c6a84b4) 49.60%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5078   +/-   ##
=========================================
  Coverage     49.60%   49.60%           
  Complexity     1904     1904           
=========================================
  Files           372      372           
  Lines         11564    11564           
  Branches       1127     1127           
=========================================
  Hits           5736     5736           
  Misses         5488     5488           
  Partials        340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nobodyiam nobodyiam merged commit ff44245 into apolloconfig:master Jan 23, 2024
@nobodyiam nobodyiam deleted the fix-5073 branch January 23, 2024 01:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Length of namespace is mis-calculated when creating new private namespace
1 participant