[SEDONA-501] ST_Split maps to wrong Java-call #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
approved these changes
Feb 22, 2024
|
Thanks for fixing this. This is great. Do you want to create another PR to fix the non-deterministic behavior of splitting polygons? |
|
Thanks. Yes, I can try take a look 👍 |
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Map Python ST_Split to Java ST_Split.
How was this patch tested?
I updated unit tests. I could not get the polygon/polygon test data (overlapping_polys) to yield a deterministic result, so I added some test data (multipoint_splitting_line) that is identical to the documentation example: https://sedona.apache.org/1.5.1/api/sql/Function/?h=st_#st_split
FYI: The non-deterministic behaviour on splitting polygons with polygons seem just to be the choice for start/end of the split.
Did this PR include necessary documentation updates?