This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add new Maven build for Scala package #13819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review, Scala] |
zachgk
suggested changes
Jan 9, 2019
piyushghai
reviewed
Jan 9, 2019
| make scalapkg | ||
| make scalainstall | ||
| cd scala-package | ||
| mvn install |
There was a problem hiding this comment.
I would rather make is : mvn clean install
There was a problem hiding this comment.
As a new user tutorial, I think it should be fine to just do install
piyushghai
reviewed
Jan 9, 2019
| @@ -17,7 +17,7 @@ Compile the Scala Package by | |||
|
|
|||
| ```bash | |||
| cd scala-package | |||
| mvn install | |||
| mvn package | |||
There was a problem hiding this comment.
Why change it from install to package ?
There was a problem hiding this comment.
Discussed offline. This seems fine.
zachgk
suggested changes
Jan 9, 2019
piyushghai
approved these changes
Jan 10, 2019
gigasquid
approved these changes
Jan 10, 2019
zachgk
approved these changes
Jan 10, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* clean up build * fix minor issue and add mkldnn * fix mx_dist problem * fix clojure build * fix skip test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up with @frankfliu PR to add maven run configurations. We also enabled MKLDNN unit test run on Scala
@frankfliu @marcoabreu @zachgk @andrewfayres @piyushghai
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.