Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Cuda 11 build fixes #19530

Merged
merged 5 commits into from
Nov 14, 2020
Merged

Cuda 11 build fixes #19530

merged 5 commits into from
Nov 14, 2020

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Nov 13, 2020 •
edited
Loading

Description

Fixes to build properly on Windows with Cuda 11.0:

  • Update multi_lamb.cu and multi_lans.cu to use cuda's pow() function instead of std::pow() and statically cast exponent to float so it matches cuda pow signature.

Fixes compilation errors:

multi_lamb.cu(53): error: calling a __host__ function("pow<float, int, (int)0> ") from a __global__ function("mxnet::op::KernelStep1<(bool)1, float, float> ") is not allowed
multi_lamb.cu(53): error: identifier "pow<float, int, (int)0> " is undefined in device code

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Joe Evans added 2 commits November 12, 2020 19:47
Don't use namespace for pow() function, since it is built into cuda m…
c76086e 
…ath library, and cast the second argument so it will find an acceptable form.
Properly case exponent.
8d6b752
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, website, windows-gpu, centos-gpu, clang, sanity, unix-cpu, miscellaneous, windows-cpu, centos-cpu, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Nov 13, 2020
This was referenced Nov 14, 2020
Merged
Closed
@josephevans josephevans changed the title [WIP] Cuda 11 build fixes Cuda 11 build fixes Nov 14, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review labels Nov 14, 2020
@josephevans josephevans mentioned this pull request Nov 14, 2020
Merged
6 tasks
@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 14, 2020
@mseth10 mseth10 merged commit 3bf556d into apache:master Nov 14, 2020
chinakook pushed a commit to chinakook/mxnet that referenced this pull request Nov 19, 2020
@josephevans @chinakook
Cuda 11 build fixes (apache#19530)
fc46073 
* Don't use namespace for pow() function, since it is built into cuda math library, and cast the second argument so it will find an acceptable form.

* Properly case exponent.

* Remove thrust library override and use default from cuda 11.0.

* Fix lint.

* Fix lint.

Co-authored-by: Joe Evans <joeev@amazon.com>
@access2rohit access2rohit mentioned this pull request Feb 17, 2021
Closed
13 tasks
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Feb 19, 2021
@josephevans
Cuda 11 build fixes (apache#19530)
86a8669 
* Don't use namespace for pow() function, since it is built into cuda math library, and cast the second argument so it will find an acceptable form.

* Properly case exponent.

* Remove thrust library override and use default from cuda 11.0.

* Fix lint.

* Fix lint.

Co-authored-by: Joe Evans <joeev@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

2 more reviewers

@leezu leezu leezu approved these changes

@szhengac szhengac szhengac approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@josephevans @mxnet-bot @leezu @szhengac @lanking520 @mseth10