[#1237] fix(trino): Fix dropping iceberg schema failure #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearvive
reviewed
Dec 25, 2023
| } catch (NonEmptySchemaException e) { | ||
| throw new TrinoException(GRAVITINO_SCHEMA_NOT_EMPTY, "Schema does not empty", e); | ||
| } catch (Exception e) { | ||
| String errorMessage = |
There was a problem hiding this comment.
Is it possible to report an error here that the array is out of bounds
There was a problem hiding this comment.
@Clearvive ,
I can't get your meaning clearly, could you provide more details about it?
There was a problem hiding this comment.
This is a common practice, and I'll refine it later. I have created the issue #1249
|
@Clearvive can you please help to review. |
jerryshao
reviewed
Dec 25, 2023
api/src/main/java/com/datastrato/gravitino/rel/SupportsSchemas.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/datastrato/gravitino/rel/SupportsSchemas.java
Outdated
Show resolved
Hide resolved
|
All unnecessary changes have been undo, please take a look again. |
This reverts commit e359931.
diqiu50
reviewed
Jan 3, 2024
| @@ -379,24 +379,15 @@ public Schema alterSchema(NameIdentifier ident, SchemaChange... changes) | |||
| @Override | |||
| public boolean dropSchema(NameIdentifier ident, boolean cascade) throws NonEmptySchemaException { | |||
There was a problem hiding this comment.
Will it only throw the NonEmptySchemaException?
There was a problem hiding this comment.
Other exceptions will also be thrown, but it's not explicitly declared.
jerryshao
reviewed
Jan 4, 2024
...ion-test/src/test/java/com/datastrato/gravitino/integration/test/trino/TrinoConnectorIT.java
Outdated
Show resolved
Hide resolved
|
API related changes have been reverted. |
jerryshao
approved these changes
Jan 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
### What changes were proposed in this pull request? Instead of catching exceptions when dropping schemas fails, throw them. ### Why are the changes needed? We can't determine whether the schema drop was successful or not based on its return value. Fix: #1237 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Existing UTs and ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of catching exceptions when dropping schemas fails, throw them.
Why are the changes needed?
We can't determine whether the schema drop was successful or not based on its return value.
Fix: #1237
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Existing UTs and ITs.