[#1047] improvement(core): Fix the issue of StringIdentifier in metalake property #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Dec 18, 2023
core/src/main/java/com/datastrato/gravitino/StringIdentifier.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/StringIdentifier.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/meta/MetalakeManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/kv/KvGarbageCollector.java
Outdated
Show resolved
Hide resolved
to removeIdFromProperties
|
@jerryshao |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ake property (#1163) ### What changes were proposed in this pull request? Remove the `stringId` from metalake property map. ### Why are the changes needed? `gravitino.identifier` is generated internally and should not be visible to users. Fix: #1047 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Existing UTs can cover it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the
stringIdfrom metalake property map.Why are the changes needed?
gravitino.identifieris generated internally and should not be visible to users.Fix: #1047
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Existing UTs can cover it.